Skip to content

Honor access token type in bearer auth policy#49542

Open
rohitsinghal4u wants to merge 1 commit into
mainfrom
rohit/msi-token-binding-core-java
Open

Honor access token type in bearer auth policy#49542
rohitsinghal4u wants to merge 1 commit into
mainfrom
rohit/msi-token-binding-core-java

Conversation

@rohitsinghal4u

Copy link
Copy Markdown
Contributor

Updates BearerTokenAuthenticationPolicy to use AccessToken.getTokenType() when setting the Authorization header. This is a Core prerequisite for PoP/MSI token binding flows while preserving Bearer as the default.\n\nValidation:\n- mvn -pl sdk/core/azure-core -Dtest=BearerTokenAuthenticationPolicyTests test -DskipCheckStyle=true -DskipRevapi=true -Dgpg.skip=true -q

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 17, 2026 23:40
@github-actions github-actions Bot added the Azure.Core azure-core label Jun 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The new null/empty token-type fallback branch is not currently covered by tests, leaving the defaulting behavior unverified.

Pull request overview

Updates BearerTokenAuthenticationPolicy in azure-core to honor AccessToken.getTokenType() when forming the Authorization header, enabling non-Bearer schemes (e.g., Pop) while retaining Bearer as the default behavior.

Changes:

  • Use AccessToken (including tokenType) when setting the Authorization header in both async and sync flows.
  • Add new unit tests asserting that a non-default token type (e.g., Pop) is used in the Authorization header.
File summaries
File Description
sdk/core/azure-core/src/main/java/com/azure/core/http/policy/BearerTokenAuthenticationPolicy.java Switch header construction to incorporate AccessToken.getTokenType() with a fallback to Bearer.
sdk/core/azure-core/src/test/java/com/azure/core/http/policy/BearerTokenAuthenticationPolicyTests.java Add async and sync tests validating that tokenType is reflected in the Authorization header.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

}
assertEquals("Pop token", authorizationHeader.get());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants