Skip to content

fix: remove extra shift in --no-telemetry flag parsing in install-azd.sh #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhvb1989 merged 2 commits into from
May 29, 2026
+3 −4
Merged

fix: remove extra shift in --no-telemetry flag parsing in install-azd.sh #8423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b19b154
fix: remove extra shift in --no-telemetry flag parsing in install-azd.sh
vhvb1989 May 28, 2026
2ebc1f1
fix: address Copilot review feedback (iteration 1)
vhvb1989 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cli/installer/install-azd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ save_error_report_if_enabled() {
collect_telemetry=$(echo "$env_collect_telemetry" | tr "[:upper:]" "[:lower:]")

# If user has opted out of telemetry return immediately
if [ "$no_telemetry" = 1 ] || [ "$collect_telemetry" = "no" ]; then
if [ "$no_telemetry" = true ] || [ "$collect_telemetry" = "no" ]; then
say_verbose "Telemetry disabled. No error report data stored."
return
fi
Expand Down Expand Up @@ -148,7 +148,7 @@ dry_run=false
skip_verify=false
symlink_folder="/usr/local/bin"
install_folder="/opt/microsoft/azd"
no_telemetry=0
no_telemetry=false
verbose=false

while [[ $# -ne 0 ]];
Expand Down Expand Up @@ -189,8 +189,7 @@ do
shift
symlink_folder="$1"
;;
--no-telemetry)
shift
-t|--no-telemetry)
no_telemetry=true
;;
-v|--verbose)
Expand Down
Loading