feat: merge-train/fairies-v5#24152
Merged
Merged
Conversation
PXE has logic to detect whether generating proofs is necessary depending on the node it's connected to (via `node.getNodeInfo()`). `EmbeddedWallet` was overriding its own default, preventing the autodetection.
…24145) Two PXE error messages linked to a docs page that no longer exists (`developers/resources/debugging/aztecnr-errors`), and suggested methods that aren't public API. - `utility_execution_oracle.ts` ("No public key registered for address") - `contract_store.ts` ("Unknown contract") Both now point at the live page `https://docs.aztec.network/developers/docs/aztec-nr/debugging#contract-errors` and recommend the real methods (`wallet.registerSender(...)` / `wallet.registerContract(...)`) instead of the nonexistent `pxe.addAccount(...)` / `server.addContracts(...)`. Discovered in http://ci.aztec-labs.com/7f36172a9dadb066
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: allow prover mode autodetection (#24151)
fix(pxe): repoint broken debugging docs link in PXE error messages (#24145)
END_COMMIT_OVERRIDE