fix(bb-sol): use cached solc in foundry config#24126
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
barretenberg/sol/foundry.tomlsosolc = "../../l1-contracts/solc-0.8.30"is inprofile.default, not under[fuzz].forge testuse the pre-downloadedl1-contracts-solcbinary instead of falling back to SVM and fetchinghttps://binaries.soliditylang.org/linux-amd64/list.jsonduring test execution.Investigation
27607587707ongh-readonly-queue/v5-next/pr-24053-bc61f8c0....ci/x10-full, loghttp://ci.aztec-labs.com/1781601708617442.cd barretenberg/sol && forge test --no-match-contract Base, loghttp://ci.aztec-labs.com/422d1d46441daa4b.binaries.soliditylang.org.Verification
cd barretenberg/sol && forge config --json | jq -r '.profile.default.solc // .solc // "<unset>"'now prints../../l1-contracts/solc-0.8.30.make l1-contracts-solcpasses.make bb-solpasses.cd barretenberg/sol && forge test --no-match-contract Basepasses: 168 tests passed, 0 failed../bootstrap.sh ciwas attempted but this checkout has nocicommand (Unknown command: ci).timeout 1800 ./bootstrap.sh ci-full-no-test-cachewas attempted as the closest repo CI entrypoint, but the local container aborted in the test engine before reaching this change; targetedbb-solverification above passed.Created by claudebox · group:
slackbot