fix(avm-transpiler): check u16 operand narrowing#24119
Draft
Kuhai9801 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #24115.
The AVM transpiler now checks Brillig memory addresses before encoding them as U16 operands instead of silently wrapping oversized values. The C ABI entrypoints convert transpilation panics into
TranspileResulterrors, so invalid inputs do not unwind across FFI.The debug-log message-size immediate is also range-checked before U16 encoding.
Checklist
Testing
git diff --checkto_u32() as u16andmessage_size.0 as u16narrowingNo local compile or test run; verification should run in CI.