feat: merge-train/fairies-v5#24117
Merged
Merged
Conversation
…y, TransientArray (#24021) `for_each` used to iterate from last to first element, with the sole purpose of making it easy to remove elements in loop. This is a behavior that makes sense when DB persisted capsules were the only mechanism available to Aztec.nr to handle arbitrary sized unconstrained collections. Back then, every capsule operation resulted in a DB transaction, which made them quite costly. Now capsules operations mostly write to memory (and commit to disk at the end of a PXE job), but also we have other pure in-memory mechanisms such as EphemeralArray and TransientArray. In the current codebase I have found no code taking advantage of the ability to remove elements directly from a `for_each` loop, so it seems a good moment to deprecate this quirk. Closes F-729
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: remove obsolete no_predicates wrappers (#7729) (#24093)
feat!: change for_each iteration order in CapsuleArray, EphemeralArray, TransientArray (#24021)
END_COMMIT_OVERRIDE