Skip to content

fix(kv-store): lazy-load skipped browser benchmark deps#24108

Merged
PhilWindle merged 1 commit into
merge-train/spartan-v5from
cb/spartan-v5-kv-store-bench-import
Jun 16, 2026
Merged

fix(kv-store): lazy-load skipped browser benchmark deps#24108
PhilWindle merged 1 commit into
merge-train/spartan-v5from
cb/spartan-v5-kv-store-bench-import

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Investigated the merge-train/spartan-v5 dequeue for train PR feat: merge-train/spartan-v5 #24053.
  • Latest dequeue was from merge-group CI, not a merge conflict: feat: merge-train/spartan-v5 #24053 is currently mergeable/clean on merge-train/spartan-v5.
  • The failing merge-group run was 27576008840 on gh-readonly-queue/v5-next/pr-24053-fc2322d6..., failing ci/x3-full via yarn-project/kv-store/scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts.
  • Root cause: skipped-by-default browser benchmarks still imported SQLite/OPFS and shared benchmark dependencies at module load, so normal CI test discovery could fail before the describe.skip path.
  • Fix: lazy-load benchmark dependencies only when VITE_BENCH=1 for the IndexedDB, SQLite-OPFS, and encrypted SQLite-OPFS map benchmarks.

Failed dashboard log: http://ci.aztec-labs.com/dbe70cb905f2df69

Verification

  • CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts from yarn-project/kv-store passes with the benchmark skipped.
  • CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/sqlite-opfs/map_bench.test.ts passes with the benchmark skipped.
  • CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/indexeddb/map_bench.test.ts passes with the benchmark skipped.
  • yarn format kv-store --check passes.

Notes: the requested root ./bootstrap.sh ci is not a valid bootstrap command in this checkout (Unknown command: ci). I also tried the apparent CI equivalent, ./bootstrap.sh ci-full-no-test-cache; it did not complete in this container because the local CI engine/tooling failed before reaching these tests.


Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 15, 2026
@PhilWindle PhilWindle marked this pull request as ready for review June 16, 2026 08:29
@PhilWindle PhilWindle merged commit 93d3d0a into merge-train/spartan-v5 Jun 16, 2026
38 of 43 checks passed
@PhilWindle PhilWindle deleted the cb/spartan-v5-kv-store-bench-import branch June 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants