feat: Refactor TLS and PSK support to use OpenSSL - #220
Merged
Conversation
- Removed feature gating for PSK-related code in CLI and configuration files. - Updated CLI argument handling for PSK options to always be available. - Transitioned from `rustls` to `openssl` for TLS connections, including client authentication and certificate verification. - Simplified the transport layer to use `tokio-openssl` for TLS streams. - Removed unused `danger` module and related certificate verification logic. - Adjusted tests and documentation to reflect the removal of feature flags and the shift to OpenSSL.
Rod-Persky
enabled auto-merge (squash)
July 6, 2026 11:28
…ompiled via OpenSSL) (#221)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and packaging process for the
taconandtacacsrs-agentdexecutables to always include OpenSSL-backed TLS and TLS 1.3 PSK support by default, removing the need for thepskfeature flag in standard builds. It also simplifies the codebase by eliminating conditional compilation for thepskfeature, and updates documentation and CI workflows to reflect these changes.Build and Packaging Process:
pskfeature flag in builds, packaging scripts, and CI workflows. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation Updates:
DEBIAN_PACKAGING.md,DEVELOPMENT.md,docs/sonic-build-guide.md) has been updated to describe the new default behavior, clarify OpenSSL requirements, and remove references to thepskfeature flag in build instructions. [1] [2] [3] [4] [5] [6] [7] [8]Codebase Simplification:
#[cfg(feature = "psk")]) related to thepskfeature have been removed from the codebase, including intacacsrs-agentd'sCargo.toml, CLI, and main logic files. This makes PSK support always available and simplifies the code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Continuous Integration (CI) Adjustments:
pskfeature from product build matrices and to always collect OpenSSL runtime DLLs on Windows, regardless of features. [1] [2] [3] [4]Summary of Most Important Changes:
Build and Packaging:
taconandtacacsrs-agentdnow always include OpenSSL-backed TLS and TLS 1.3 PSK support by default; thepskfeature flag is no longer needed in build scripts or CI workflows. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation:
pskfeature flag. [1] [2] [3] [4] [5] [6] [7] [8]Codebase Simplification:
#[cfg(feature = "psk")]conditional compilation and related feature flag handling from the codebase, making PSK support unconditional. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]