chore: upgrade api-resource-schema to 0.0.19 - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s schema/resource tooling to align with aryeo/api-resource-schema 0.0.18, including the new versioned-schema configuration pattern used by the upstream package.
Changes:
- Bump
aryeo/api-resource-schema(and related tooling packages) to newer versions and refreshcomposer.lock. - Add a test fixture
ApiVersionenum and apply schema versioning via the new#[Version(...)]attribute in fixture resources. - Wire schema version selection into the local
make:resourcewrapper and test configuration.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Fixtures/Support/Schemas/ApiVersion.php | Adds a fixture Version enum used to configure schema-version support in tests. |
| tests/Fixtures/Support/Http/Api/Resources/Json/Posts.php | Updates Collects attribute import path to match the upgraded package structure. |
| tests/Fixtures/Support/Http/Api/Resources/Json/Post.php | Adds #[Version(...)] and updates attribute imports to match the upgraded package structure. |
| testbench.yaml | Removes the file that previously only exported tooling path env vars. |
| src/Support/Http/Api/Console/Commands/MakeResource/MakeResourceTest.php | Configures api-resource-schema.version for tests using WithConfig. |
| src/Support/Http/Api/Console/Commands/MakeResource/MakeResource.php | Passes --schema-version through to the upstream make-resource command. |
| composer.json | Updates dependency versions and migrates tooling config into extra.tooling (paths/rules). |
| composer.lock | Locks updated dependency graph resulting from the upgrade. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jrseliga
marked this pull request as draft
August 12, 2026 15:14
jrseliga
force-pushed
the
upgrade-api-resource-schema-to-0.0.17
branch
from
August 12, 2026 15:22
ef7f570 to
bddd764
Compare
jrseliga
marked this pull request as ready for review
August 12, 2026 15:23
jrseliga
enabled auto-merge
August 12, 2026 15:23
jrseliga
force-pushed
the
upgrade-api-resource-schema-to-0.0.17
branch
from
August 12, 2026 15:27
bddd764 to
c99353e
Compare
jrseliga
marked this pull request as draft
August 12, 2026 15:45
auto-merge was automatically disabled
August 12, 2026 15:45
Pull request was converted to draft
api-resource-schema to 0.0.18api-resource-schema to 0.0.19
jrseliga
force-pushed
the
upgrade-api-resource-schema-to-0.0.17
branch
from
August 12, 2026 16:00
3e3b8b9 to
bbb36e8
Compare
jrseliga
force-pushed
the
upgrade-api-resource-schema-to-0.0.17
branch
from
August 12, 2026 16:28
559d997 to
b6470d3
Compare
jrseliga
marked this pull request as ready for review
August 12, 2026 16:32
jrseliga
enabled auto-merge
August 12, 2026 16:32
coryrose1
approved these changes
Aug 12, 2026
Comment on lines
38
to
43
| [ | ||
| 'name' => $this->entity->name->toString(), | ||
| '--namespace' => $namespace, | ||
| '--schema-version' => $this->apiVersion->toString(), | ||
| '--force' => $this->option('force'), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.