Potential fix for code scanning alert no. 2: Use of a broken or weak cryptographic hashing algorithm on sensitive data - #8
Merged
Conversation
…cryptographic hashing algorithm on sensitive data Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Artixcore
marked this pull request as ready for review
July 29, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Artixcore/artixcore-contentPilot/security/code-scanning/2
Use a password-hashing/KDF function for API-key verifier storage and verification, instead of fast HMAC-SHA256. The best low-impact fix here is to replace
_hashwithhashlib.pbkdf2_hmac(SHA-256, high iteration count) and keep the existing return type/flow (hexstring) so DB schema and call sites remain unchanged.What to change (core/workspace_api_keys.py):
_hash(around lines 59–60), replacehmac.new(..., hashlib.sha256).hexdigest()with PBKDF2-HMAC-SHA256._pepper()as the secret salt/pepper input.PBKDF2_ITERATIONS = 310_000) near other constants.This preserves behavior (deterministic hash for create/verify), requires no call-site changes, and addresses both alert variants.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.