fix: setting roles translations - #432
Closed
eldon922 wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing — this one has already landed. The same fix came in via #417 (commit 18b1b29), merged a few minutes ago. That PR was opened a week earlier and bundled two related bugs from #375 alongside this line — the Nothing wrong with the diagnosis, though: you landed on exactly the right line and the right namespace, independently. Thanks for taking the time to file it, and sorry it turned out to be a duplicate — that's on the queue being backed up, not on you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
Test plan
npm run typecheckclean.npm run lint— no new errors beyond the pre-existing backlog.npm run buildsucceeds.Related