Skip to content

fix: setting roles translations - #432

Closed
eldon922 wants to merge 1 commit into
ArnasDon:mainfrom
eldon922:fix/setting-roles-translation
Closed

fix: setting roles translations#432
eldon922 wants to merge 1 commit into
ArnasDon:mainfrom
eldon922:fix/setting-roles-translation

Conversation

@eldon922

@eldon922 eldon922 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

What changed

Test plan

  • npm run typecheck clean.
  • npm run lint — no new errors beyond the pre-existing backlog.
  • npm run build succeeds.
  • Feature / fix manually exercised in the browser (or the reason it can't be).

Related

@eldon922
eldon922 requested a review from ArnasDon as a code owner July 27, 2026 04:40
@ArnasDon

Copy link
Copy Markdown
Owner

Closing — this one has already landed. settings-overview.tsx:43 on main now reads useTranslations('Settings.roles'), so the diff here is a no-op against current main.

The same fix came in via #417 (commit 18b1b29), merged a few minutes ago. That PR was opened a week earlier and bundled two related bugs from #375 alongside this line — the scopesHint rich-tag and the <SelectValue /> raw-enum rendering.

Nothing wrong with the diagnosis, though: you landed on exactly the right line and the right namespace, independently. Thanks for taking the time to file it, and sorry it turned out to be a duplicate — that's on the queue being backed up, not on you.

@ArnasDon ArnasDon closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants