fix(i18n): sync ko.json with en.json and add a locale key parity test - #419
Open
opastorello wants to merge 2 commits into
Open
fix(i18n): sync ko.json with en.json and add a locale key parity test#419opastorello wants to merge 2 commits into
opastorello wants to merge 2 commits into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418.
Two keys landed in
en.jsonwithout reachingko.json—Settings.sections.quick-replies(8bbbe0a) andContacts.detailView.tabs.tags(6a8744c).src/i18n/request.tsonly falls back per-file, not per-key, so Korean users see the raw keypaths in the settings nav and on the contact tags tab.First commit adds the two labels:
빠른 답장and태그, matching the termsko.jsonalready uses for these features (Inbox.composer.quickReplies*uses 빠른 답장 six times, and 태그 is what every other tags label uses —Inbox.sidebar.tags,Contacts.page.tableColumns.tags, etc.).Inbox.composer.quickRepliesEmptyliterally tells the user설정 → 빠른 답장에서 추가하세요, so the nav label has to match that wording.Second commit adds
src/i18n/messages.test.tsso this stops recurring. On currentmainit fails naming exactly the two keys above:It also checks the reverse direction — keys present in a translation but absent from
en.json— which would have flagged the root-levelrolesworkaround blocks that #417 makes unnecessary. Runs insidenpm test, so CI picks it up with no workflow change.Overlap note: the review thread on #417 asked for the same
quick-repliesline; taking it here instead so the parity test lands green on its own. The two PRs touch different parts ofko.json, so they don't conflict and merge in either order.Test plan
npm run typecheckcleannpm run lint— 0 errors, no new warningsnpm test— both parity tests pass; suite otherwise unchanged frommain(the 3currency.test.tsfailures on local Node 24 are pre-existing ICU differences; CI runs Node 20 where they pass)Settings.sections.quick-replies→ 빠른 답장,Contacts.detailView.tabs.tags→ 태그