build: remove --start-group/--end-group linker flags (CentOS no longer targeted) - #3838
Merged
Conversation
YoshuaLisasi
approved these changes
Aug 4, 2026
Removed 'fix/remove-ld-group' branch from workflow triggers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
--start-group/--end-groupGNU linker flags that were added in PR #3561 to work around circular static library dependencies on CentOS 7. Since CentOS 7 is no longer a target platform, these flags are no longer needed.Changes
LINKER:--start-groupandLINKER:--end-groupfromadd_link_options(). These were causing the linker warningmissing --end-group; added as last command line optionon every build becauseadd_link_options()applies them globally rather than at the end of the link line.fix/remove-ld-groupto the list of triggered branches so the Oracle 8 CI builds this branch and validates the change.Rationale
add_link_options()applies--end-groupto every target, but ld requires it as the absolute last argument — hence the warning on every link step.target_link_options()per-target instead ofadd_link_options()to ensure correct placement.