Skip to content

feat: extra-output [ANT-5006] - #3799

Merged
flomnes merged 27 commits into
developfrom
feature/extra-outputs
Aug 4, 2026
Merged

feat: extra-output [ANT-5006]#3799
flomnes merged 27 commits into
developfrom
feature/extra-outputs

Conversation

@JasonMarechal25

Copy link
Copy Markdown
Contributor

No description provided.

@JasonMarechal25 JasonMarechal25 changed the title feat: STS profit feat: extra-output [ANT-5006] Jul 10, 2026

@flomnes flomnes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @claude !

Comment thread src/solver/optimisation/LegacyExtraOutputs.cpp
Comment on lines 150 to 151

constexpr double nearLossOfLoadCutoff = 5.;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to explain the value, e.g

  // 5 MW threshold for near LoL detection
  constexpr double nearLossOfLoadCutoff = 5.;

Comment thread src/solver/optimisation/LegacyExtraOutputs.cpp
Comment thread src/libs/antares/exception/CMakeLists.txt Outdated
Jason Marechal and others added 6 commits July 15, 2026 08:20
Signed-off-by: Jason Marechal <jason.marechal@pm.me>
Signed-off-by: Jason Marechal <jason.marechal@pm.me>
Signed-off-by: Jason Marechal <jason.marechal@pm.me>
Signed-off-by: Jason Marechal <jason.marechal@pm.me>
@JasonMarechal25
JasonMarechal25 marked this pull request as ready for review July 15, 2026 08:18
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@flomnes
flomnes merged commit ff6e880 into develop Aug 4, 2026
10 checks passed
@flomnes
flomnes deleted the feature/extra-outputs branch August 4, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants