fix(maintenance): fix multiple services creation - #3328
Closed
sylvlecl wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
changed the title
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
marked this pull request as ready for review
August 5, 2026 12:34
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| app.dependency_overrides[get_study_service] = lambda: study_service | ||
| app.dependency_overrides[get_config] = lambda: config | ||
| app.dependency_overrides[get_output_service] = lambda: output_service | ||
| app.dependency_overrides[get_login_service] = lambda: Mock() |
| app.dependency_overrides[get_config] = lambda: CONFIG | ||
| app.dependency_overrides[get_output_service] = lambda: output_service | ||
| app.dependency_overrides[get_file_transfer_manager] = lambda: file_transfer_manager | ||
| app.dependency_overrides[get_login_service] = lambda: Mock() |
sylvlecl
commented
Aug 5, 2026
| engine = init_db_engine(config, auto_upgrade_db=False) | ||
| init_db_singleton(custom_engine=engine, session_args=SESSION_ARGS) | ||
| core_services = create_core_services(config=config) | ||
| services = create_services(config=config) |
Member
Author
There was a problem hiding this comment.
In this method invocation we re-created the core services, effectively creating duplicates.
I got an error on my local env with metrics being added multiple times.
Member
Author
|
Should not be needed following #3331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Services should be created only once.
Also, aligns naming of all services into
Servicesdataclass.