Skip to content

Treat missing trait declaration as not builtin in trait_impl_is_builtin #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Treat missing trait declaration as not builtin in trait_impl_is_builtin #1137

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c25fd5
Treat missing trait declaration as not builtin in trait_impl_is_builtin
SAY-5 Jun 18, 2026
e77e170
Merge branch 'main' into fix-trait-impl-builtin-notfound
SAY-5 Jul 18, 2026
835e0db
Merge branch 'main' into fix-trait-impl-builtin-notfound
SAY-5 Jul 20, 2026
f387085
Merge branch 'main' into fix-trait-impl-builtin-notfound
SAY-5 Jul 22, 2026
01dc8da
Merge branch 'main' into fix-trait-impl-builtin-notfound
SAY-5 Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/Translate.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,20 +1069,25 @@ let trait_impl_is_builtin (ctx : gen_ctx) (id : Pure.trait_impl_id) : bool =
[%silent_unwrap_opt_span] None
(TraitImplId.Map.find_opt id ctx.trans_trait_impls)
in
let trait_decl =
Pure.TraitDeclId.Map.find trait_impl.impl_trait.trait_decl_id
(* The trait declaration may have been dropped earlier while the impl is
still exported (e.g. mutually recursive trait clusters): in that case we
can't be looking at a builtin impl, so treat it as not builtin. *)
match
Pure.TraitDeclId.Map.find_opt trait_impl.impl_trait.trait_decl_id
ctx.trans_trait_decls
in
let builtin_info =
let open ExtractBuiltin in
let trait_impl =
TraitImplId.Map.find trait_impl.def_id ctx.crate.trait_impls
in
match_name_with_generics_find_opt ctx.trans_ctx trait_decl.item_meta.name
trait_impl.impl_trait.generics
(builtin_trait_impls_map ())
in
Option.is_some builtin_info
with
| None -> false
| Some trait_decl ->
let builtin_info =
let open ExtractBuiltin in
let trait_impl =
TraitImplId.Map.find trait_impl.def_id ctx.crate.trait_impls
in
match_name_with_generics_find_opt ctx.trans_ctx
trait_decl.item_meta.name trait_impl.impl_trait.generics
(builtin_trait_impls_map ())
in
Option.is_some builtin_info

(** Export a trait declaration. *)
let export_trait_decl (fmt : Format.formatter) (_config : gen_config)
Expand Down