Skip to content

fix: Fixes bug in settings UI #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 14 commits into from
Jun 26, 2026
+56 −2
Merged

fix: Fixes bug in settings UI #2388

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a8bb9b0
fix: App settings ui bug
claycuy Jun 25, 2026
a5cb273
format linting
claycuy Jun 25, 2026
229442c
fix: if-else to switch-case
claycuy Jun 25, 2026
eb7cd89
fix: settings/terminalSettings.js
claycuy Jun 25, 2026
d2653f3
fix: settings/appSettings.js
claycuy Jun 25, 2026
8f8faa2
fix: settings/appSettings.js
claycuy Jun 25, 2026
6ee121e
fix: settings/appSettings.js
claycuy Jun 25, 2026
408653a
Update src/settings/appSettings.js
claycuy Jun 25, 2026
6ef0fc7
fix: settings/previewSettings.js
claycuy Jun 25, 2026
336e508
fix: capitalize strings
claycuy Jun 25, 2026
239f511
fix
claycuy Jun 25, 2026
b62665a
fix
claycuy Jun 25, 2026
e23392f
Merge branch 'Acode-Foundation:main' into fix/settings-ui
claycuy Jun 25, 2026
c112c2a
Merge branch 'Acode-Foundation:main' into fix/settings-ui
claycuy Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/settings/appSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,16 @@ export default function otherSettings() {
key: "quickToolsTriggerMode",
text: strings["quicktools trigger mode"],
value: values.quickToolsTriggerMode,
valueText: (value) => value.capitalize(),
valueText: (value) => {
const options = {
[appSettings.QUICKTOOLS_TRIGGER_MODE_CLICK]:
strings["quicktools-trigger:click"],
[appSettings.QUICKTOOLS_TRIGGER_MODE_TOUCH]:
strings["quicktools-trigger:touch"],
};

return options[value] ?? (value != null ? value.capitalize() : value);
},
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment thread
claycuy marked this conversation as resolved.
select: [
[
appSettings.QUICKTOOLS_TRIGGER_MODE_CLICK,
Expand Down Expand Up @@ -307,7 +316,10 @@ export default function otherSettings() {
key: "console",
text: strings.console,
value: values.console,
select: [appSettings.CONSOLE_LEGACY, appSettings.CONSOLE_ERUDA],
select: [
[appSettings.CONSOLE_LEGACY, "Legacy"],
[appSettings.CONSOLE_ERUDA, "Eruda"],
],
info: strings["settings-info-app-console"],
category: categories.advanced,
},
Expand Down
7 changes: 7 additions & 0 deletions src/settings/previewSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ export default function previewSettings() {
key: "previewMode",
text: strings["preview mode"],
value: values.previewMode,
valueText: (value) => {
const options = {
[appSettings.PREVIEW_MODE_BROWSER]: strings.browser,
[appSettings.PREVIEW_MODE_INAPP]: strings.inapp,
};
return options[value] || value.capitalize();
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
},
select: [
[appSettings.PREVIEW_MODE_BROWSER, strings.browser],
[appSettings.PREVIEW_MODE_INAPP, strings.inapp],
Expand Down
28 changes: 28 additions & 0 deletions src/settings/terminalSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ export default function terminalSettings() {
key: "fontWeight",
text: strings["terminal:font weight"],
value: terminalValues.fontWeight,
valueText: (value) => {
const tuple = [
["normal", strings["terminal:normal"]],
["bold", strings["terminal:bold"]],
].find((item) => item[0] === value);

return tuple ? tuple[1] : value;
},
select: [
["normal", strings["terminal:normal"]],
["bold", strings["terminal:bold"]],
Expand All @@ -88,6 +96,7 @@ export default function terminalSettings() {
info: strings["info-fontWeight"],
category: categories.display,
},

{
key: "letterSpacing",
text: strings["letter spacing"],
Expand All @@ -108,6 +117,14 @@ export default function terminalSettings() {
key: "cursorStyle",
text: strings["terminal:cursor style"],
value: terminalValues.cursorStyle,
valueText: (value) => {
const option = [
["block", strings["terminal:block"]],
["underline", strings["terminal:underline"]],
["bar", strings["terminal:bar"]],
].find((item) => item[0] === value);
return option ? option[1] : value;
},
select: [
["block", strings["terminal:block"]],
["underline", strings["terminal:underline"]],
Expand All @@ -120,6 +137,17 @@ export default function terminalSettings() {
key: "cursorInactiveStyle",
text: strings["terminal:cursor inactive style"],
value: terminalValues.cursorInactiveStyle,
valueText: (value) => {
const options = [
["outline", strings["terminal:inactive outline"]],
["block", strings["terminal:inactive block"]],
["underline", strings["terminal:inactive underline"]],
["bar", strings["terminal:inactive bar"]],
["none", strings["terminal:inactive none"]],
];
const option = options.find((item) => item[0] === value);
return option ? option[1] : value;
},
select: [
["outline", strings["terminal:inactive outline"]],
["block", strings["terminal:inactive block"]],
Expand Down