Fix IS-05 test_15: More lenient channel symbols for undefined channel-orders#901
Open
kaihagseth wants to merge 1 commit into
Open
Fix IS-05 test_15: More lenient channel symbols for undefined channel-orders#901kaihagseth wants to merge 1 commit into
kaihagseth wants to merge 1 commit into
Conversation
…order is U01..U64 In SMPTE 2110-30, undefined channel-order explicitly allows any channel symbols. The test tried to accommodate for that by falling back to setting channel orders it did not recognize to undefined, which in turn got compared with the reported channel-order string from the SDP. The issue with this approach is that it's perfectly legal to reference known sequences of symbols as an undefined channel-order. For example, reporting the symbols "L,R,C" in the source and "U03" in the SDP would previously fail the test, because the framework aggressively grouped them and expected the SDP channel-order to be "ST,U01". Instead of generating a single string as the one true answer for a given symbol order, this fix allows a wider range of SDPs to be valid for a set of listed channel symbols by verifying them sequentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SMPTE 2110-30, undefined channel-order explicitly allows any channel symbols.
The test tried to accommodate for that by falling back to setting channel orders
it did not recognize to undefined, which in turn got compared with the reported
channel-order string from the SDP.
The issue with this approach is that it's perfectly legal to reference known
sequences of symbols as an undefined channel-order. For example, reporting the
symbols "L,R,C" in the source and "U03" in the SDP would previously fail the test,
because the framework aggressively grouped them and expected the SDP channel-
order to be "ST,U01".
Instead of generating a single string as the one true answer for a given symbol
order, this fix allows a wider range of SDPs to be valid for a set of listed
channel symbols by verifying them sequentially.