Skip to content

added support for seperating idle engineers from selection - #137

Open
vjt4 wants to merge 1 commit into
4z0t:developfrom
vjt4:patch-3
Open

added support for seperating idle engineers from selection#137
vjt4 wants to merge 1 commit into
4z0t:developfrom
vjt4:patch-3

Conversation

@vjt4

@vjt4 vjt4 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Just like when the option "separate idle builders" is selected in the main option's menu.

Summary by CodeRabbit

  • New Features
    • Added an “Idle Construction” selection group for construction units that are currently idle.
    • Idle construction units now display a dedicated idle icon in the selection list.

Just like when the option "separate idle builders" is selected in the main option's menu.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e016ffd2-82ee-4f46-b521-ff5f92a58943

📥 Commits

Reviewing files that changed from the base of the PR and between e46780e and 581e710.

📒 Files selected for processing (1)
  • mods/ReUI.Construction/Modules/Components/SelectedUnits.lua

📝 Walkthrough

Walkthrough

Adds an idle construction unit matcher that identifies idle construction-category units, displays an idle icon, and registers them as the IDLECONSTRUCTION selection group.

Changes

Idle construction grouping

Layer / File(s) Summary
Idle construction matcher and registration
mods/ReUI.Construction/Modules/Components/SelectedUnits.lua
Adds matching and idle-icon display logic for idle construction units, then registers the matcher in the ordered selection groups.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to separate idle engineers from the selection list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant