fix: add missing dependencies to setup.cfg#2460
Open
Helbronner wants to merge 1 commit into3b1b:masterfrom
Open
fix: add missing dependencies to setup.cfg#2460Helbronner wants to merge 1 commit into3b1b:masterfrom
Helbronner wants to merge 1 commit into3b1b:masterfrom
Conversation
- Add `trimesh` and `pywavefront` to `install_requires` in `setup.cfg` - Sort dependencies alphabetically to comply with project linting standards - Resolve `ModuleNotFoundError` during runtime after an editable install Closes 3b1b#2459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trimeshandpywavefronttoinstall_requiresinsetup.cfgModuleNotFoundErrorduring runtime after an editable installCloses #2459
Motivation
As discussed in #2459,
trimeshandpywavefrontare currently listed inrequirements.txtbut are missing fromsetup.cfg. This discrepancy leads to a silent failure in two critical scenarios:pip install -e .will have an incomplete environment. While the command finishes without errors, the library will crash at runtime with aModuleNotFoundError.pip install manimglwill also result in a broken installation for the same reason, as PyPI distributions rely on the metadata defined insetup.cfg.This Pull Request ensures that all necessary dependencies are centrally managed in
setup.cfg, guaranteeing a consistent and robust setup experience for both developers and end-users.Proposed changes
trimeshandpywavefrontin theinstall_requireslist withinsetup.cfgTest
I verified the fix by performing a clean installation in an isolated virtual environment to ensure
pipcorrectly resolves the new dependencies fromsetup.cfg.Code:
Result:
The environment was initialized successfully without requiring manual dependency installation. The
OpeningManimExamplescene rendered correctly, confirming that the runtime errors are resolved.Thanks for your time and review!