Skip to content

fix: sanitize subprocess call in sounds.py #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: sanitize subprocess call in sounds.py #2454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions manimlib/utils/sounds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import os
import subprocess
import threading
import platform
Expand All @@ -19,14 +20,22 @@ def get_full_sound_file_path(sound_file_name: str) -> str:
def play_sound(sound_file):
"""Play a sound file using the system's audio player"""
full_path = get_full_sound_file_path(sound_file)

# Resolve the real path and validate it exists to prevent path traversal attacks
full_path = os.path.realpath(full_path)
if not os.path.isfile(full_path):
raise FileNotFoundError(f"Sound file not found: {full_path}")

system = platform.system()

if system == "Windows":
# Windows
# Windows - escape single quotes in path to prevent PowerShell injection
# Single-quoted PowerShell strings only require doubling of single quotes
escaped_path = full_path.replace("'", "''")
subprocess.Popen(
["powershell", "-c", f"(New-Object Media.SoundPlayer '{full_path}').PlaySync()"],
shell=True, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL
)
["powershell", "-c", f"(New-Object Media.SoundPlayer '{escaped_path}').PlaySync()"],
shell=False, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL
)
elif system == "Darwin":
# macOS
subprocess.Popen(
Expand Down