Update versioning to use importlib#2384
Closed
ahmrr wants to merge 1 commit into3b1b:masterfrom
Closed
Conversation
Contributor
|
Unfortunately, this PR (apparently useful) duplicates another one: #2360. |
Author
|
You're right, my apologies; I should have checked the other pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using
pkg_resourcesis deprecated and slated for removal:Thus, running
manimon e.g. Python 3.11.13 results in the following warning:UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The > pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.Proposed changes
I simply updated the versioning code in
__init__.pyto useimportlib.metadatainstead ofpkg_resources.Test
Code:
$ manim --versionResult:
ManimGL v1.7.2