[DNM] Initial Astreaus Dialogue System Rip#631
Open
Dark98 wants to merge 1 commit into
Open
Conversation
advnau
reviewed
Feb 26, 2023
advnau
left a comment
advnau
left a comment
Contributor
There was a problem hiding this comment.
just some initial thoughts
| */ | ||
| public abstract class Dialogue { | ||
|
|
||
| private static Player player; |
| * @param dialogue | ||
| * The dialogue to sent. | ||
| */ | ||
| public final DialogueFactory sendDialogue(Dialogue dialogue) { |
Contributor
There was a problem hiding this comment.
should we set player boolean to them using the new system here?
| * | ||
| * @return The instance of this factory. | ||
| */ | ||
| public void clear() { |
Contributor
There was a problem hiding this comment.
we should set player.dialoguePlugin to false here in the clear method.
ipkpjersi
reviewed
Dec 21, 2023
| public final class GeneralStoreDialogue extends Dialogue { | ||
| @Override | ||
| public void sendDialogues(DialogueFactory factory) { | ||
| factory.getPlayer().dialoguePlugin = true; |
Contributor
There was a problem hiding this comment.
I would name the variable here dialogue, not factory, since dialogue is a more descriptive name of what it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.