Fix export types - #251
Open
ahmed-sudowrite wants to merge 4 commits into
Open
Conversation
17Amir17
reviewed
Dec 29, 2024
17Amir17
left a comment
17Amir17
left a comment
Collaborator
There was a problem hiding this comment.
Hey, and thanks for contributing!
I'm just seeing one type error
Author
Interesting, have you tried doing I'll bump our version to match the latest minor, since it's the one that'll be installed anyways. |
Collaborator
|
This looks good - but tests are failing for some reason will need to look into it |
Author
|
Can we try rerunning the test? Doesn't look like the tests are failing because of any of the changes in the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types for useTenTap were broken, now they are not hehe