[CI only] Validate rebased fix/socks5 — do not merge - #1
Closed
0typos wants to merge 6 commits into
Closed
Conversation
…SOCKS5 handshake, and lower default to 1s
The reverse SOCKS5 connect handshake is a single byte written into the tunnel by the client and read back by the server before it replies to the SOCKS client. Only the websocket and http2 server handlers implement that read; the webtransport handler documents that it keeps its previous, ungated behaviour. The client, however, sent the byte for any transport. Over wts:// it was therefore never consumed as a handshake and arrived as the first byte of the payload, corrupting the stream. Gate the write on the transport so both sides agree on when the handshake is present.
Owner
Author
|
CI validation complete: 15/15 jobs green on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary draft PR to run the full CI matrix against the rebase of
fix/socks5onto upstream14168c5.Not for merge — this exists only to exercise the
checkjob (fmt, taplo, clippy, nextest x2) and the cross-platform build matrix, since the upstream PR erebe#486 is waiting on maintainer approval to run.Will be closed once results are in.