Audit Settings crash reports and harden settings presentation

[zachyzissou]

Problem

Settings was reported crashing on build 51. Even if current builds fixed this, Settings needs a focused crash/regression audit because it is a central surface for identity, iCloud, playback settings, counts, and account actions.

Acceptance criteria

• Reproduce or confirm fixed across current TestFlight and local main.
• Review Sentry/MetricKit or local crash logs if available.
• Add smoke UI coverage for opening Settings from Home and Library.
• Verify sign-out/unsubscribe/destructive dialogs use Tuner modal surfaces and do not crash when dismissed.

Agent execution contract

Readiness: agent:low-thinking-ready
Lane: Settings stability

Start in these files:

• OffScript/AppSettings.swift
• OffScript/HomeView.swift
• OffScript/LibraryView.swift
• OffScriptTests/OffScriptUITests.swift
• CHANGELOG.md

Required verification:

• xcodebuild test -project OffScript.xcodeproj -scheme OffScript -destination 'platform=iOS Simulator,OS=latest,name=iPhone 17 Pro' -only-testing:OffScriptTests CODE_SIGNING_ALLOWED=NO
• Focused UI smoke opening Settings from Home and Library.

Non-goals / guardrails:

• Do not remove identity/iCloud diagnostics to silence crashes.
• Do not replace Apple-required controls with custom clones.

PR expectation: Settings hardening PR with crash-path hypothesis and smoke proof.

Low-thinking agents must follow docs/AGENT_EXECUTION_RUNBOOK.md. If the touched code falls outside the files above, stop and tighten the issue or ask for senior review before continuing.

[zachyzissou]

Status (post-session 2026-04-30)

Three PRs shipped against this:

• #150 Library entry + reopen-cycle Settings UI smoke
• #156 VoiceOver labels for destructive Settings keys
• #167 Sign-out confirmation dismiss smoke

Acceptance state:

• ✅ Smoke UI coverage for opening Settings from Home and Library — covered.
• ✅ Verify destructive dialogs use Tuner modal surfaces and don't crash when dismissed — covered.
• ⏸️ Reproduce or confirm fixed across current TestFlight and local main — needs owner action (real-device verification post Xcode Cloud catch-up).
• ⏸️ Review Sentry/MetricKit or local crash logs if available — needs owner action (requires Sentry / MetricKit access I don't have).

The two remaining bullets are owner-only. Recommend keeping open until the Sentry triage lands; don't reassign to a low-thinking agent — every code-side bullet has shipped.