Service Account file credentials support#39
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for loading YDB Service Account credentials from a JSON file path, extending existing credential preparation logic in ydb_dbapi to cover an additional configuration style.
Changes:
- Add
service_account_filehandling inprepare_credentials()to buildServiceAccountCredentialsfrom a file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+161
to
+163
| service_account_file = credentials.get("service_account_file") | ||
| if service_account_file: | ||
| return ydb.iam.ServiceAccountCredentials.from_file(service_account_file) |
vgvoleg
force-pushed
the
sa_file_credentials
branch
from
ebcb833 to
0197b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.