fix: downgrade resource module ImportError log from warning to debug on Windows - #187
Merged
Merged
Conversation
…e on Windows Agent-Logs-Url: https://github.com/xhluca/bm25s/sessions/631cce8f-60bf-47e3-aca5-44d8192ab9d0 Co-authored-by: xhluca <21180505+xhluca@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix logger warning during imports on Windows
fix: downgrade resource module ImportError log from warning to debug on Windows
May 6, 2026
Owner
|
@copilot that's fine but warning should be inside the usage of resource |
Agent-Logs-Url: https://github.com/xhluca/bm25s/sessions/9a8b5893-8b28-4c71-ba01-4d4126b15c35 Co-authored-by: xhluca <21180505+xhluca@users.noreply.github.com>
Contributor
Author
Done in 8b17975. The |
xhluca
marked this pull request as ready for review
May 6, 2026 21:56
Owner
|
@copilot fix the error |
Agent-Logs-Url: https://github.com/xhluca/bm25s/sessions/31474705-fbd9-4eed-bbb9-f011558ccd5e Co-authored-by: xhluca <21180505+xhluca@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger.warningtologger.debugat import time (no stderr noise on every import)logger.warninginsideget_max_memory_usagewhenresourceisNone(warn only when the feature is actually attempted)