Bump pinned sdk version - #57
Conversation
|
Claude finished @The64thRealm's task in 2m 19s —— View job Code ReviewReviewed the 3-line bump against Findings1. The pin must match what
The Verified
Could not verify (no network / no
|
| @@ -1 +1 @@ | |||
| 1.3.43 | |||
| 1.3.45 | |||
There was a problem hiding this comment.
This pin must equal what play ships, not npm latest — the release gate hard-fails otherwise.
.github/workflows/auto-tag.yml:39-55 blocks tag creation unless this file matches .packages["node_modules/@wvdsh/sdk-js"].version in wvdsh/play's latest release package-lock.json:
if [ "$pinned" != "$shipped" ]; then
echo "::error::wavedash dev would inject @wvdsh/sdk-js@$pinned but play $tag ships $shipped..."
exit 1
fiSince this PR also bumps Cargo.toml to 0.1.93, merging fires that job immediately — and if play's live release ships 1.3.43 or 1.3.44, the 0.1.93 tag/release never gets created.
scripts/bump-sdk-js.sh with no argument pins to npm latest, which is precisely the drift this gate exists to catch — the script's own docs call it out (scripts/bump-sdk-js.sh:17-18):
Keep the pin in step with the
@wvdsh/sdk-jsversion play bundles in prod (play/package.json)
The jump 1.3.43 → 1.3.45 (skipping 1.3.44) reads like an npm-latest resolve rather than a play-parity bump, so worth confirming before merge:
gh api repos/wvdsh/play/contents/package-lock.json \
--jq '.content' -H "Accept: application/vnd.github.raw" \
| jq -r '.packages["node_modules/@wvdsh/sdk-js"].version'If play ships something other than 1.3.45, pin to that value instead.
bumped to 1.3.45