feat(security): wip#1267
Conversation
|
Found two concrete issues:
I could not run |
you should admit urself in a scrapyard |
eth44
left a comment
There was a problem hiding this comment.
nit: rename allow-http feature to dangerously-allow-http
|
Found one concrete issue:
I could not run |
|
No concrete merge-blocking issues found in the PR diff. I could not run |
|
Found two concrete issues:
I did not run tests in this read-only review environment. |
Shared client builder (security-utils)
Renamed http_client_builder() → client_builder() (leaving the old name as possible to use, but with deprecated warning)
TLS 1.3 minimum enforced
https_only(true) in production, enforced by clippy ( see below)
CA pinning: 9 specific CAs (Amazon Root CA 1–4, Starfield G2, Google Trust Services R1–R4), system trust store disabled
SHA256 hash verification of embedded cert bytes at runtime
allow-http = []in security-utils feature for crates with local HTTP test servers, only to be used as dev-dependency feature flag.
All production reqwest clients migrated to security_utils :: client_builder()
orb-backend-status
orb-connd
orb-speed-test
orb-attest
orb-se050-reprovision
Explicit exceptions
Clippy enforcement
Pending
Test orb-software changes on the orb
priv-orb-core: bump orb-security-utils rev, rename http_client_builder() → client_builder(), add clippy.toml — deferred until orb-software changes are tested
Check orb-relay-messages