-
Notifications
You must be signed in to change notification settings - Fork 397
fix(meetings): validate reaction relay route binding #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mickelr
wants to merge
15
commits into
webex:next
Choose a base branch
from
mickelr:fix/reaction4bo
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6ff96db
feat(webinar 5k): rollback
mickelr f086b54
Merge branch 'webex:next' into next
mickelr 5239a6c
Merge branch 'webex:next' into next
mickelr c1cbcb0
Merge branch 'webex:next' into next
mickelr 62e1703
Merge branch 'webex:next' into next
mickelr 3bc9c2c
Merge branch 'webex:next' into next
mickelr 1d98b2d
Merge branch 'webex:next' into next
mickelr a6e9d66
Merge branch 'webex:next' into next
mickelr 277a5cb
Merge branch 'webex:next' into next
mickelr f45554d
Merge branch 'webex:next' into next
mickelr 24830e8
Merge branch 'webex:next' into next
mickelr b3c1511
Merge branch 'webex:next' into next
mickelr 59d3733
Merge branch 'webex:next' into next
mickelr e8fc7e9
Merge branch 'webex:next' into next
mickelr d04eb82
fix(meetings): validate reaction relay route binding
mickelr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,4 +60,7 @@ type RelayEventData = { | |
|
|
||
| export type RelayEvent = { | ||
| data: RelayEventData; | ||
| headers?: { | ||
| route?: string; | ||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the practice-session socket is connected, this always compares every relay event to the practice binding, even events delivered on the default LLM channel. Mercury tags each incoming envelope with its
sessionIdand emits default events onevent:relay.eventwhile practice events useevent:relay.event:llm-practice-session; because both listeners remain registered, a default-session reaction withheaders.route === llm.getBinding()will now be skipped whenever the practice channel is also connected. Use the event/session that delivered the relay event to choose the binding instead of global practice connectivity.Useful? React with 👍 / 👎.