Skip to content

Commit fe223c7

Browse files
committed
fix(ci): fix vp create e2e arg ordering and env var scope
Split template-args from create-args so --package-manager is placed before the -- separator. Move VP_OVERRIDE_PACKAGES/VP_VERSION to job-level env. Add ls -la for debugging lockfile issues.
1 parent a9b9140 commit fe223c7

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

.github/workflows/test-vp-create.yml

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,18 +121,24 @@ jobs:
121121
template:
122122
- name: monorepo
123123
create-args: vite:monorepo --directory test-project
124+
template-args: ''
124125
verify-command: vp run ready
125126
- name: application
126-
create-args: vite:application --directory test-project -- --template vanilla-ts
127+
create-args: vite:application --directory test-project
128+
template-args: '-- --template vanilla-ts'
127129
verify-command: vp run build
128130
- name: library
129131
create-args: vite:library --directory test-project
132+
template-args: ''
130133
verify-command: vp run build
131134
package-manager:
132135
- pnpm
133136
- npm
134137
- yarn
135138
- bun
139+
env:
140+
VP_OVERRIDE_PACKAGES: '{"vite":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","vitest":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz","@voidzero-dev/vite-plus-core":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","@voidzero-dev/vite-plus-test":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz"}'
141+
VP_VERSION: 'file:${{ github.workspace }}/tmp/tgz/vite-plus-0.0.0.tgz'
136142
steps:
137143
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
138144

@@ -161,14 +167,12 @@ jobs:
161167
162168
- name: Run vp create ${{ matrix.template.name }} with ${{ matrix.package-manager }}
163169
working-directory: ${{ runner.temp }}
164-
env:
165-
VP_OVERRIDE_PACKAGES: '{"vite":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","vitest":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz","@voidzero-dev/vite-plus-core":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","@voidzero-dev/vite-plus-test":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz"}'
166-
VP_VERSION: 'file:${{ github.workspace }}/tmp/tgz/vite-plus-0.0.0.tgz'
167170
run: |
168171
vp create ${{ matrix.template.create-args }} \
169172
--no-interactive \
170173
--no-agent \
171-
--package-manager ${{ matrix.package-manager }}
174+
--package-manager ${{ matrix.package-manager }} \
175+
${{ matrix.template.template-args }}
172176
173177
- name: Verify project structure
174178
working-directory: ${{ runner.temp }}/test-project
@@ -178,6 +182,10 @@ jobs:
178182
echo "✓ package.json exists"
179183
cat package.json
180184
185+
# List all files for debugging
186+
echo "--- Project root files ---"
187+
ls -la
188+
181189
# Check correct lockfile exists
182190
case "${{ matrix.package-manager }}" in
183191
pnpm)

0 commit comments

Comments
 (0)