Merge branch 'main' into agent-consolidation

Author: cpojer

packages/cli/binding/src/cli.rs

@@ -517,6 +517,21 @@ fn build_pack_cache_inputs() -> Vec<UserInputEntry> {
     ]
 }
 
+/// Cache input entries for the check command.
+/// The vp check subprocess is a full vp CLI process (not resolved to a binary like
+/// build/lint/fmt), so it accesses additional directories that must be excluded:
+/// - `.vite-temp`: config compilation cache, read+written during vp CLI startup
+/// - `.vite/task-cache`: task runner state files that change after each run
+fn check_cache_inputs() -> Vec<UserInputEntry> {
+    vec![
+        UserInputEntry::Auto(AutoInput { auto: true }),
+        exclude_glob("!node_modules/.vite-temp/**", InputBase::Workspace),
+        exclude_glob("!node_modules/.vite-temp/**", InputBase::Package),
+        exclude_glob("!node_modules/.vite/task-cache/**", InputBase::Workspace),
+        exclude_glob("!node_modules/.vite/task-cache/**", InputBase::Package),
+    ]
+}
+
 fn merge_resolved_envs(
     envs: &Arc<FxHashMap<Arc<OsStr>, Arc<OsStr>>>,
     resolved_envs: Vec<(String, String)>,
@@ -587,10 +602,14 @@ impl CommandHandler for VitePlusCommandHandler {
         };
         match cli_args {
             CLIArgs::Synthesizable(SynthesizableSubcommand::Check { .. }) => {
-                // Check is a composite command — run as a subprocess in task scripts
-                Ok(HandledCommand::Synthesized(
-                    command.to_synthetic_plan_request(UserCacheConfig::disabled()),
-                ))
+                // Check is a composite command (fmt + lint) — run as a subprocess in task scripts
+                Ok(HandledCommand::Synthesized(command.to_synthetic_plan_request(
+                    UserCacheConfig::with_config(EnabledCacheConfig {
+                        env: Some(Box::new([Str::from("OXLINT_TSGOLINT_PATH")])),
+                        untracked_env: None,
+                        input: Some(check_cache_inputs()),
+                    }),
+                )))
             }
             CLIArgs::Synthesizable(subcmd) => {
                 let resolved =

packages/cli/snap-tests-global/new-vite-monorepo-bun/snap.txt

@@ -20,7 +20,7 @@ vite.config.ts
   ],
   "type": "module",
   "scripts": {
-    "ready": "vp fmt && vp lint && vp run -r test && vp run -r build",
+    "ready": "vp check && vp run -r test && vp run -r build",
     "dev": "vp run website#dev",
     "prepare": "vp config"
   },

packages/cli/snap-tests-global/new-vite-monorepo/snap.txt

@@ -16,7 +16,7 @@ vite.config.ts
   "private": true,
   "type": "module",
   "scripts": {
-    "ready": "vp fmt && vp lint && vp run -r test && vp run -r build",
+    "ready": "vp check && vp run -r test && vp run -r build",
     "dev": "vp run website#dev",
     "prepare": "vp config"
   },
@@ -140,7 +140,7 @@ vite.config.ts
   "private": true,
   "type": "module",
   "scripts": {
-    "ready": "vp fmt && vp lint && vp run -r test && vp run -r build",
+    "ready": "vp check && vp run -r test && vp run -r build",
     "dev": "vp run website#dev",
     "prepare": "vp config"
   },

packages/cli/snap-tests/check-cache-disabled/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "check-cache-disabled-test",
+  "type": "module",
+  "scripts": {
+    "check": "vp check"
+  }
+}

packages/cli/snap-tests/check-cache-disabled/snap.txt

@@ -0,0 +1,5 @@
+> vp run check # vp check should have cache disabled without run.cache
+$ vp check ⊘ cache disabled
+pass: All 3 files are correctly formatted (<variable>ms, <variable> threads)
+pass: Found no warnings or lint errors in 1 file (<variable>ms, <variable> threads)
+

packages/cli/snap-tests/check-cache-disabled/src/index.js

@@ -0,0 +1,5 @@
+function hello() {
+  return "hello";
+}
+
+export { hello };

packages/cli/snap-tests/check-cache-disabled/steps.json

@@ -0,0 +1,3 @@
+{
+  "commands": ["vp run check # vp check should have cache disabled without run.cache"]
+}

packages/cli/snap-tests/check-cache-enabled/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "check-cache-enabled-test",
+  "type": "module",
+  "scripts": {
+    "check": "vp check"
+  }
+}

packages/cli/snap-tests/check-cache-enabled/snap.txt

@@ -0,0 +1,20 @@
+> vp run check # first run should be cache miss
+$ vp check
+pass: All 4 files are correctly formatted (<variable>ms, <variable> threads)
+pass: Found no warnings or lint errors in 2 files (<variable>ms, <variable> threads)
+
+
+> vp run check # second run should be cache hit
+$ vp check ◉ cache hit, replaying
+pass: All 4 files are correctly formatted (<variable>ms, <variable> threads)
+pass: Found no warnings or lint errors in 2 files (<variable>ms, <variable> threads)
+
+---
+vp run: cache hit, <variable>ms saved.
+
+> echo 'export const foo = 1;' > src/foo.js
+> vp run check # third run should be cache miss after new file added
+$ vp check ○ cache miss: 'foo.js' added in 'src', executing
+pass: All 5 files are correctly formatted (<variable>ms, <variable> threads)
+pass: Found no warnings or lint errors in 3 files (<variable>ms, <variable> threads)
+

packages/cli/snap-tests/check-cache-enabled/src/index.js

@@ -0,0 +1,5 @@
+function hello() {
+  return "hello";
+}
+
+export { hello };