Skip to content

Commit 93ebe40

Browse files
committed
chore(workflow): broaden final-error checklist for upgrade-deps
The closing prompt instruction only pointed at `build-upstream` failures, but the step also runs lint, `just build`, `pnpm test`, and snap tests. Enumerate every error class Claude is expected to fix, and call out snap-test regressions explicitly since `pnpm test` exits 0 even when snapshot outputs diverge — the agent must inspect the snap-test git diff and fix real regressions while leaving cosmetic version-string drift in place.
1 parent 18f0349 commit 93ebe40

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

.github/workflows/upgrade-deps.yml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,26 @@ jobs:
116116
the task complete if either `just build` fails, `pnpm bootstrap-cli:ci && pnpm test`
117117
fails, or the snap-test diff shows an apparent regression.
118118
119-
Help me fix the errors in `build-upstream` steps if exists.
120-
No need to commit changes after your fixing we have a following step to commit all file changes.
119+
Help me fix every error that surfaces during this step. That includes, at
120+
minimum:
121+
- Failures in the `build-upstream` action (non-zero exit from any step inside
122+
`.github/actions/build-upstream/action.yml`).
123+
- `pnpm run lint` errors.
124+
- `just build` failures.
125+
- `pnpm bootstrap-cli:ci && pnpm test` failures.
126+
- Snap-test regressions: `pnpm test` always exits 0 even when snapshot outputs
127+
differ, so you MUST inspect the `git diff` on
128+
`packages/cli/snap-tests/**/snap.txt` and
129+
`packages/cli/snap-tests-global/**/snap.txt` and fix any change that looks
130+
like a real regression (e.g., unexpected stack traces, missing output,
131+
diverging CLI behavior). Cosmetic drift caused by the upstream upgrade
132+
itself (e.g., a bumped version string in help output) is acceptable —
133+
leave those in place.
134+
- `cargo check --all-targets --all-features` errors if any Rust code was
135+
modified, and stale `cargo shear` findings if `Cargo.toml` changed.
136+
137+
Do NOT commit any changes — a later workflow step handles the commit for all
138+
modified files.
121139
claude_args: |
122140
--model opus --allowedTools "Bash,Edit,Replace,NotebookEditCell"
123141
additional_permissions: |

0 commit comments

Comments
 (0)