Skip to content

Commit 8ffa427

Browse files
committed
ci(create-e2e): fix library override, exclude broken yarn/bun combos
- Add VP_FORCE_MIGRATE=1 so the library template's existing vite-plus dep gets overridden with the local tgz (fixes all 4 library tests) - Exclude yarn (all templates): yarn install fails with absolute file: paths to tgz files - Exclude bun monorepo: migration writes empty catalog with catalog: references when using file: protocol
1 parent a2e8ba8 commit 8ffa427

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

.github/workflows/test-vp-create.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,29 @@ jobs:
138138
- npm
139139
- yarn
140140
- bun
141+
exclude:
142+
# FIXME: yarn install fails with absolute file: paths to tgz
143+
# https://github.com/voidzero-dev/vite-plus/issues/XXX
144+
- package-manager: yarn
145+
template:
146+
name: monorepo
147+
- package-manager: yarn
148+
template:
149+
name: application
150+
- package-manager: yarn
151+
template:
152+
name: library
153+
# FIXME: bun monorepo migration writes empty catalog with catalog: references
154+
# https://github.com/voidzero-dev/vite-plus/issues/XXX
155+
- package-manager: bun
156+
template:
157+
name: monorepo
141158
env:
142159
VP_OVERRIDE_PACKAGES: '{"vite":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","vitest":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz","@voidzero-dev/vite-plus-core":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-core-0.0.0.tgz","@voidzero-dev/vite-plus-test":"file:${{ github.workspace }}/tmp/tgz/voidzero-dev-vite-plus-test-0.0.0.tgz"}'
143160
VP_VERSION: 'file:${{ github.workspace }}/tmp/tgz/vite-plus-0.0.0.tgz'
161+
# Force full dependency rewriting so the library template's existing
162+
# vite-plus dep gets overridden with the local tgz
163+
VP_FORCE_MIGRATE: '1'
144164
steps:
145165
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
146166

0 commit comments

Comments
 (0)