fix(check): respect oxlint exit code so denyWarnings fails vp check

`vp check` was unconditionally resetting the status to success whenever
lint reported only warnings, masking the non-zero exit code produced by
oxlint when `options.denyWarnings` (or `--deny-warnings`) is enabled.
Drop the override and trust oxlint's exit code so warning-only runs fail
the check when warnings have been opted in as failures.

Closes #1424

Author: fengmk2

packages/cli/binding/src/check/mod.rs

@@ -176,9 +176,12 @@ pub(crate) async fn execute_check(
                 }
             }
             Some(Err(failure)) => {
+                // Trust the oxlint exit code: oxlint exits 0 for warning-only
+                // output by default and exits non-zero when `denyWarnings` (or
+                // `--deny-warnings`) promotes warnings to failures. The heading
+                // still reflects the findings (warnings vs errors).
                 if failure.errors == 0 && failure.warnings > 0 {
                     output::warn(lint_message_kind.warning_heading());
-                    status = ExitStatus::SUCCESS;
                 } else {
                     output::error(lint_message_kind.issue_heading());
                 }

packages/cli/snap-tests/check-lint-warn-deny-warnings/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "check-lint-warn-deny-warnings",
+  "version": "0.0.0",
+  "private": true
+}

packages/cli/snap-tests/check-lint-warn-deny-warnings/snap.txt

@@ -0,0 +1,13 @@
+[1]> vp check
+pass: All 4 files are correctly formatted (<variable>ms, <variable> threads)
+warn: Lint warnings found
+⚠ eslint(no-console): Unexpected console statement.
+   ╭─[src/index.js:2:3]
+ 1 │ function hello() {
+ 2 │   console.log("hello");
+   ·   ───────────
+ 3 │ }
+   ╰────
+  help: Delete this console statement.
+
+Found 0 errors and 1 warning in 2 files (<variable>ms, <variable> threads)

packages/cli/snap-tests/check-lint-warn-deny-warnings/src/index.js

@@ -0,0 +1,5 @@
+function hello() {
+  console.log("hello");
+}
+
+export { hello };

packages/cli/snap-tests/check-lint-warn-deny-warnings/steps.json

@@ -0,0 +1,6 @@
+{
+  "env": {
+    "VITE_DISABLE_AUTO_INSTALL": "1"
+  },
+  "commands": ["vp check"]
+}

packages/cli/snap-tests/check-lint-warn-deny-warnings/vite.config.ts

@@ -0,0 +1,10 @@
+export default {
+  lint: {
+    options: {
+      denyWarnings: true,
+    },
+    rules: {
+      "no-console": "warn",
+    },
+  },
+};