Merge branch 'main' into feat/embed-release-version

Author: fengmk2

.cargo/config.toml

@@ -4,10 +4,17 @@ WORKSPACE_DIR = { value = "rolldown", relative = true }
 
 [build]
 rustflags = ["--cfg", "tokio_unstable"] # also update .github/workflows/ci.yml
+
 # fix sqlite build error on linux
 [target.'cfg(target_os = "linux")']
 rustflags = ["--cfg", "tokio_unstable", "-C", "link-args=-Wl,--warn-unresolved-symbols"]
 
+# Increase stack size on Windows to avoid stack overflow
+[target.'cfg(all(windows, target_env = "msvc"))']
+rustflags = ["--cfg", "tokio_unstable", "-C", "link-arg=/STACK:8388608"]
+[target.'cfg(all(windows, target_env = "gnu"))']
+rustflags = ["--cfg", "tokio_unstable", "-C", "link-arg=-Wl,--stack,8388608"]
+
 [unstable]
 bindeps = true
 

.claude/skills/add-ecosystem-ci/SKILL.md

@@ -25,7 +25,11 @@ gh api repos/OWNER/REPO/commits/BRANCH --jq '.sha'
 
 Fetch the repository's root to check if the main package.json is in a subdirectory (like `web/`, `app/`, `frontend/`).
 
-### 2.2 Auto-detect Commands from GitHub Workflows
+### 2.2 Check if Project Already Uses Vite-Plus
+
+Check the project's root `package.json` for `vite-plus` in `dependencies` or `devDependencies`. If the project already uses vite-plus, set `forceFreshMigration: true` in `repo.json`. This tells `patch-project.ts` to set `VITE_PLUS_FORCE_MIGRATE=1` so `vp migrate` forces full dependency rewriting instead of skipping with "already using Vite+".
+
+### 2.3 Auto-detect Commands from GitHub Workflows
 
 Fetch the project's GitHub workflow files to detect available commands:
 
@@ -43,7 +47,7 @@ Look for common patterns in workflow files:
 - Commands like: `lint`, `build`, `test`, `type-check`, `typecheck`, `format`, `format:check`
 - Map detected commands to `vp` equivalents: `vp run lint`, `vp run build`, etc.
 
-### 2.3 Ask User to Confirm
+### 2.4 Ask User to Confirm
 
 Present the auto-detected configuration and ask user to confirm or modify:
 
@@ -62,7 +66,8 @@ Present the auto-detected configuration and ask user to confirm or modify:
        "repository": "https://github.com/owner/repo.git",
        "branch": "main",
        "hash": "full-commit-sha",
-       "directory": "web" // only if subdirectory is needed
+       "directory": "web", // only if subdirectory is needed
+       "forceFreshMigration": true // only if project already uses vite-plus
      }
    }
    ```
@@ -79,12 +84,42 @@ Present the auto-detected configuration and ask user to confirm or modify:
 
 ## Step 4: Verify
 
-Test the clone locally:
+### 4.1 Build fresh tgz packages
+
+Always rebuild tgz packages from latest source to avoid using stale cached versions:
+
+```bash
+# Rebuild the global CLI first (includes Rust binary + NAPI binding)
+pnpm bootstrap-cli
+
+# Pack fresh tgz files into tmp/tgz/
+rm -rf tmp/tgz && mkdir -p tmp/tgz
+cd packages/core && pnpm pack --pack-destination ../../tmp/tgz && cd ../..
+cd packages/test && pnpm pack --pack-destination ../../tmp/tgz && cd ../..
+cd packages/cli && pnpm pack --pack-destination ../../tmp/tgz && cd ../..
+ls -la tmp/tgz
+```
+
+### 4.2 Clone and test locally
 
 ```bash
 node ecosystem-ci/clone.ts project-name
 ```
 
+### 4.3 Patch and run commands
+
+```bash
+# Run from the ecosystem-ci temp directory
+cd $(node -e "const os=require('os'); console.log(os.tmpdir() + '/vite-plus-ecosystem-ci')")
+
+# Migrate the project (uses tgz files from tmp/tgz/)
+node /path/to/vite-plus/ecosystem-ci/patch-project.ts project-name
+
+# Run the configured commands
+cd project-name
+vp run build
+```
+
 3. **Add OS exclusion to `.github/workflows/e2e-test.yml`** (if not running on both):
 
    For ubuntu-only:
@@ -110,4 +145,5 @@ node ecosystem-ci/clone.ts project-name
 - The `directory` field is optional - only add it if the package.json is not in the project root
 - If `directory` is specified in repo.json, it must also be specified in the workflow matrix
 - `patch-project.ts` automatically handles running `vp migrate` in the correct directory
+- `forceFreshMigration` is required for projects that already have `vite-plus` in their package.json — it sets `VITE_PLUS_FORCE_MIGRATE=1` so `vp migrate` forces full dependency rewriting instead of skipping
 - OS exclusions are added to the existing `exclude` section in the workflow matrix

.claude/skills/bump-vite-task/SKILL.md

@@ -0,0 +1,102 @@
+---
+name: bump-vite-task
+description: Bump vite-task git dependency to the latest main commit. Use when you need to update the vite-task crates (fspy, vite_glob, vite_path, vite_str, vite_task, vite_workspace) in vite-plus.
+allowed-tools: Read, Grep, Glob, Edit, Bash, Agent, WebFetch
+---
+
+# Bump vite-task to Latest Main
+
+Update the vite-task git dependency in `Cargo.toml` to the latest commit on the vite-task main branch, fix any breaking changes, and create a PR.
+
+## Steps
+
+### 1. Get current and target commits
+
+- Read `Cargo.toml` and find the current `rev = "..."` for any vite-task git dependency (e.g., `vite_task`, `vite_path`, `fspy`, `vite_glob`, `vite_str`, `vite_workspace`). They all share the same revision.
+- Get the latest commit hash on vite-task's main branch:
+  ```bash
+  git ls-remote https://github.com/voidzero-dev/vite-task.git refs/heads/main
+  ```
+
+### 2. Update Cargo.toml
+
+- Replace **all** occurrences of the old commit hash with the new one in `Cargo.toml`. There are 6 crate entries that reference the same vite-task revision: `fspy`, `vite_glob`, `vite_path`, `vite_str`, `vite_task`, `vite_workspace`.
+
+### 3. Ensure upstream dependencies are cloned
+
+- `cargo check` requires the `./rolldown` and `./vite` directories to exist (many workspace path dependencies point to `./rolldown/crates/...`).
+- Locally, clone them using the commit hashes from `packages/tools/.upstream-versions.json`.
+- CI handles this automatically via the `.github/actions/clone` action.
+
+### 4. Verify compilation
+
+- Run `cargo check` to ensure the new vite-task compiles without errors.
+- If there are compilation errors, these are **breaking changes** from vite-task. Fix them in the vite-plus codebase (the consuming side), not in vite-task.
+- Common breaking changes include: renamed functions/methods, changed function signatures, new required fields in structs, removed public APIs.
+
+### 5. Run tests
+
+- Run `cargo test -p vite_command -p vite_error -p vite_install -p vite_js_runtime -p vite_migration -p vite_shared -p vite_static_config -p vite-plus-cli -p vite_global_cli` to run the vite-plus crate tests.
+- Note: Some tests require network access (e.g., `vite_install::package_manager` tests, `vite_global_cli::commands::env` tests). These may fail in sandboxed environments. Verify they also fail on the main branch before dismissing them.
+- Note: `cargo test -p vite_task` will NOT work because vite_task is a git dependency, not a workspace member.
+
+### 6. Update snap tests
+
+vite-task changes often affect CLI output, which means snap tests need updating. Common output changes:
+
+- **Status icons**: e.g., cache hit/miss indicators may change
+- **New CLI options**: e.g., new flags added to `vp run` that show up in help output
+- **Cache behavior messages**: e.g., new summary lines about cache status
+- **Task output formatting**: e.g., step numbering, separator lines
+
+To update snap tests:
+
+1. Push your changes and let CI run the snap tests.
+2. CI will show the diff in the E2E test logs if snap tests fail.
+3. Extract the diff from CI logs and apply it locally.
+4. Check all three platforms (Linux, Mac, Windows) since they may have slightly different snap test coverage.
+5. Watch for trailing newline issues - ensure snap files end consistently.
+
+Snap test files are at `packages/cli/snap-tests/*/snap.txt` and `packages/cli/snap-tests-global/*/snap.txt`.
+
+### 7. Review changelog and update docs
+
+- Fetch the vite-task `CHANGELOG.md` diff between old and new commits to see what changed:
+  ```
+  https://raw.githubusercontent.com/voidzero-dev/vite-task/<new-hash>/CHANGELOG.md
+  ```
+- Review each changelog entry and determine if it affects user-facing behavior: new CLI options, changed defaults, new config fields, removed features, etc.
+- The changelog contains links to the corresponding vite-task PRs. For complex changes, check the PR description and code diff (especially any docs changes in the PR) to understand the full scope of the change.
+- If user-facing changes are found, update the relevant docs in `docs/` (e.g., `docs/guide/`, `docs/config/`).
+- Common doc updates include:
+  - **New CLI flags/options**: Update the relevant config doc (e.g., `docs/config/run.md`, `docs/config/build.md`)
+  - **New features or commands**: Add or update the relevant guide page (e.g., `docs/guide/cache.md`)
+  - **Changed defaults or behavior**: Update any docs that describe the old behavior
+  - **Removed/deprecated options**: Remove or mark as deprecated in the relevant docs
+- If no user-facing changes are found, skip this step.
+
+### 8. Create the PR
+
+- Commit message: `chore: bump vite-task to <short-hash>`
+- PR title: `chore: bump vite-task to <short-hash>`
+- PR body: Link to vite-task CHANGELOG.md diff between old and new commits:
+  ```
+  https://github.com/voidzero-dev/vite-task/compare/<old-hash>...<new-hash>#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
+  ```
+
+### 9. Verify CI
+
+Wait for CI and ensure the `done` check passes. Key checks to monitor:
+
+- **Lint**: Clippy and format checks
+- **Test** (Linux, Mac, Windows): Rust unit tests
+- **CLI E2E test** (Linux, Mac, Windows): Snap tests - most likely to fail on a vite-task bump
+- **Run task**: Task runner integration tests
+- **Cargo Deny**: License/advisory checks (may have pre-existing failures unrelated to bump)
+
+The only **required** status check for merging is `done`, which aggregates the other checks (excluding Cargo Deny).
+
+## Notes
+
+- Building the full CLI locally (`pnpm bootstrap-cli`) requires the rolldown Node.js package to be built first, which is complex. Prefer relying on CI for snap test generation.
+- `Cargo.lock` is automatically updated by cargo when you change the revision in `Cargo.toml`.

.devcontainer/devcontainer.json

@@ -26,7 +26,8 @@
         }
       }
     }
-  }
+  },
+  "postCreateCommand": "curl -fsSL https://vite.plus | bash"
   // Use 'mounts' to make the cargo cache persistent in a Docker Volume.
   // "mounts": [
   // 	{

.github/actions/build-upstream/action.yml

@@ -25,7 +25,13 @@ runs:
       id: cache-key
       shell: bash
       run: |
-        echo "key=napi-binding-v3-${{ inputs.target }}-${{ env.RELEASE_BUILD }}-${{ env.DEBUG }}-${{ env.VERSION }}-${{ env.NPM_TAG }}-${{ hashFiles('packages/tools/.upstream-versions.json', 'Cargo.lock', 'crates/**/*.rs', 'crates/*/Cargo.toml', 'packages/cli/binding/**/*.rs', 'packages/cli/binding/Cargo.toml', 'Cargo.toml', '.cargo/config.toml', 'packages/cli/package.json', 'packages/cli/build.ts') }}" >> $GITHUB_OUTPUT
+        echo "key=napi-binding-v3-${{ inputs.target }}-${{ env.RELEASE_BUILD }}-${{ env.DEBUG }}-${{ env.VERSION }}-${{ env.NPM_TAG }}-${{ hashFiles('packages/tools/.upstream-versions.json', 'Cargo.lock', 'crates/**/*.rs', 'crates/*/Cargo.toml', 'packages/cli/binding/**/*.rs', 'packages/cli/binding/Cargo.toml', 'Cargo.toml', '.cargo/config.toml', 'packages/cli/package.json', 'packages/cli/build.ts', 'packages/cli/tsdown.config.ts') }}" >> $GITHUB_OUTPUT
+
+    # Resolve the Rust target directory (CARGO_TARGET_DIR from setup-rust, or default "target")
+    - name: Resolve Rust target directory
+      id: rust-target
+      shell: bash
+      run: echo "dir=${CARGO_TARGET_DIR:-target}" >> $GITHUB_OUTPUT
 
     # Cache NAPI bindings and Rust CLI binary (the slow parts, especially on Windows)
     - name: Restore NAPI binding cache
@@ -38,16 +44,17 @@ runs:
           packages/cli/binding/index.d.ts
           packages/cli/binding/index.cjs
           packages/cli/binding/index.d.cts
-          target/${{ inputs.target }}/release/vp
-          target/${{ inputs.target }}/release/vp.exe
-          target/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-setup.exe
         key: ${{ steps.cache-key.outputs.key }}
 
-    # Apply Vite+ branding patches to rolldown-vite source (CI checks out
-    # upstream rolldown-vite which doesn't have branding patches)
-    - name: Brand rolldown-vite
+    # Apply Vite+ branding patches to vite source (CI checks out
+    # upstream vite which doesn't have branding patches)
+    - name: Brand vite
       shell: bash
-      run: pnpm exec tool brand-rolldown-vite
+      run: pnpm exec tool brand-vite
 
     # Build upstream TypeScript packages first (don't depend on native bindings)
     - name: Build upstream TypeScript packages
@@ -59,25 +66,44 @@ runs:
         pnpm --filter "@voidzero-dev/*" build
         pnpm --filter vite-plus build-ts
 
+    # Install zig + cargo-zigbuild for musl cross-compilation (napi-cross only supports gnu)
+    - name: Add musl Rust target
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
+      shell: bash
+      run: rustup target add ${{ inputs.target }}
+
+    - name: Setup zig (musl)
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
+      uses: mlugg/setup-zig@d1434d08867e3ee9daa34448df10607b98908d29 # v2.2.1
+      with:
+        version: 0.15.2
+
+    - name: Install cargo-zigbuild (musl)
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
+      uses: taiki-e/install-action@f916cfac5d8efd040e250d0cd6b967616504b3a4 # v2.68.32
+      with:
+        tool: cargo-zigbuild
+
     # NAPI builds - only run on cache miss (slow, especially on Windows)
     # Must run before vite-plus TypeScript builds which depend on the bindings
-    - name: Build NAPI bindings (x86_64-linux)
+    - name: Build NAPI bindings (Linux gnu)
       shell: bash
-      if: steps.cache-restore.outputs.cache-hit != 'true' && inputs.target == 'x86_64-unknown-linux-gnu'
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'linux') && !contains(inputs.target, 'musl')
       run: |
         pnpm --filter=vite-plus build-native --target ${{ inputs.target }} --use-napi-cross
       env:
         TARGET_CC: clang
+        TARGET_CFLAGS: ${{ contains(inputs.target, 'aarch64') && '-D_BSD_SOURCE' || '' }}
         DEBUG: napi:*
 
-    - name: Build NAPI bindings (aarch64-linux)
+    - name: Build NAPI bindings (Linux musl)
       shell: bash
-      if: steps.cache-restore.outputs.cache-hit != 'true' && inputs.target == 'aarch64-unknown-linux-gnu'
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
       run: |
-        pnpm --filter=vite-plus build-native --target ${{ inputs.target }} --use-napi-cross
+        pnpm --filter=vite-plus build-native --target ${{ inputs.target }} -x
       env:
         TARGET_CC: clang
-        TARGET_CFLAGS: '-D_BSD_SOURCE'
+        TARGET_CFLAGS: ${{ contains(inputs.target, 'aarch64') && '-D_BSD_SOURCE' || '' }}
         DEBUG: napi:*
 
     - name: Build NAPI bindings (non-Linux targets)
@@ -88,23 +114,24 @@ runs:
       env:
         DEBUG: napi:*
 
-    - name: Build Rust CLI binary (x86_64-linux)
-      if: steps.cache-restore.outputs.cache-hit != 'true' && inputs.target == 'x86_64-unknown-linux-gnu'
+    - name: Build Rust CLI binary (Linux gnu)
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'linux') && !contains(inputs.target, 'musl')
       shell: bash
       run: |
         pnpm exec napi build --use-napi-cross --target ${{ inputs.target }} --release -p vite_global_cli
       env:
         TARGET_CC: clang
+        TARGET_CFLAGS: ${{ contains(inputs.target, 'aarch64') && '-D_BSD_SOURCE' || '' }}
         DEBUG: napi:*
 
-    - name: Build Rust CLI binary (aarch64-linux)
-      if: steps.cache-restore.outputs.cache-hit != 'true' && inputs.target == 'aarch64-unknown-linux-gnu'
+    - name: Build Rust CLI binary (Linux musl)
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'musl')
       shell: bash
       run: |
-        pnpm exec napi build --use-napi-cross --target ${{ inputs.target }} --release -p vite_global_cli
+        pnpm exec napi build -x --target ${{ inputs.target }} --release -p vite_global_cli
       env:
         TARGET_CC: clang
-        TARGET_CFLAGS: '-D_BSD_SOURCE'
+        TARGET_CFLAGS: ${{ contains(inputs.target, 'aarch64') && '-D_BSD_SOURCE' || '' }}
         DEBUG: napi:*
 
     - name: Build Rust CLI binary (non-Linux targets)
@@ -117,6 +144,11 @@ runs:
       shell: bash
       run: cargo build --release --target ${{ inputs.target }} -p vite_trampoline
 
+    - name: Build installer binary (Windows only)
+      if: steps.cache-restore.outputs.cache-hit != 'true' && contains(inputs.target, 'windows')
+      shell: bash
+      run: cargo build --release --target ${{ inputs.target }} -p vite_installer
+
     - name: Save NAPI binding cache
       if: steps.cache-restore.outputs.cache-hit != 'true'
       uses: actions/cache/save@94b89442628ad1d101e352b7ee38f30e1bef108e # v5
@@ -127,9 +159,10 @@ runs:
           packages/cli/binding/index.d.ts
           packages/cli/binding/index.cjs
           packages/cli/binding/index.d.cts
-          target/${{ inputs.target }}/release/vp
-          target/${{ inputs.target }}/release/vp.exe
-          target/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-shim.exe
+          ${{ steps.rust-target.outputs.dir }}/${{ inputs.target }}/release/vp-setup.exe
         key: ${{ steps.cache-key.outputs.key }}
 
     # Build vite-plus TypeScript after native bindings are ready

.github/actions/clone/action.yml

@@ -15,12 +15,12 @@ outputs:
 runs:
   using: 'composite'
   steps:
-    - name: Output rolldown and rolldown-vite hash
+    - name: Output rolldown and vite hash
       shell: bash
       id: upstream-versions
       run: |
         node -e "console.log('ROLLDOWN_HASH=' + require('./packages/tools/.upstream-versions.json').rolldown.hash)" >> $GITHUB_OUTPUT
-        node -e "console.log('ROLLDOWN_VITE_HASH=' + require('./packages/tools/.upstream-versions.json')['rolldown-vite'].hash)" >> $GITHUB_OUTPUT
+        node -e "console.log('ROLLDOWN_VITE_HASH=' + require('./packages/tools/.upstream-versions.json')['vite'].hash)" >> $GITHUB_OUTPUT
 
     - name: Output ecosystem ci project hash
       shell: bash
@@ -31,16 +31,16 @@ runs:
         node -e "console.log('ECOSYSTEM_CI_PROJECT_REPOSITORY=' + require('./ecosystem-ci/repo.json')['${{ inputs.ecosystem-ci-project }}'].repository.replace('https://github.com/', '').replace('.git', ''))" >> $GITHUB_OUTPUT
         echo "ECOSYSTEM_CI_PROJECT_PATH=${{ runner.temp }}/vite-plus-ecosystem-ci/${{ inputs.ecosystem-ci-project }}" >> $GITHUB_OUTPUT
 
-    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
         repository: rolldown/rolldown
         path: rolldown
         ref: ${{ steps.upstream-versions.outputs.ROLLDOWN_HASH }}
 
-    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
         repository: vitejs/vite
-        path: rolldown-vite
+        path: vite
         ref: ${{ steps.upstream-versions.outputs.ROLLDOWN_VITE_HASH }}
 
     # Disable autocrlf to preserve LF line endings on Windows