Skip to content

Commit 42bff2d

Browse files
committed
fix vp release tagging and verification
1 parent c646a39 commit 42bff2d

20 files changed

Lines changed: 315 additions & 93 deletions

File tree

Cargo.lock

Lines changed: 36 additions & 82 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ rolldown_plugin_asset_module = { path = "./rolldown/crates/rolldown_plugin_asset
258258
rolldown_plugin_bundle_analyzer = { path = "./rolldown/crates/rolldown_plugin_bundle_analyzer" }
259259
rolldown_plugin_chunk_import_map = { path = "./rolldown/crates/rolldown_plugin_chunk_import_map" }
260260
rolldown_plugin_copy_module = { path = "./rolldown/crates/rolldown_plugin_copy_module" }
261-
rolldown_plugin_data_url = { path = "./rolldown/crates/rolldown_plugin_data_url" }
261+
rolldown_plugin_data_uri = { path = "./rolldown/crates/rolldown_plugin_data_uri" }
262262
rolldown_plugin_esm_external_require = { path = "./rolldown/crates/rolldown_plugin_esm_external_require" }
263263
rolldown_plugin_hmr = { path = "./rolldown/crates/rolldown_plugin_hmr" }
264264
rolldown_plugin_isolated_declaration = { path = "./rolldown/crates/rolldown_plugin_isolated_declaration" }
@@ -285,6 +285,7 @@ rolldown_plugin_vite_reporter = { path = "./rolldown/crates/rolldown_plugin_vite
285285
rolldown_plugin_vite_resolve = { path = "./rolldown/crates/rolldown_plugin_vite_resolve" }
286286
rolldown_plugin_vite_transform = { path = "./rolldown/crates/rolldown_plugin_vite_transform" }
287287
rolldown_plugin_vite_wasm_fallback = { path = "./rolldown/crates/rolldown_plugin_vite_wasm_fallback" }
288+
rolldown_plugin_vite_wasm_helper = { path = "./rolldown/crates/rolldown_plugin_vite_wasm_helper" }
288289
rolldown_plugin_vite_web_worker_post = { path = "./rolldown/crates/rolldown_plugin_vite_web_worker_post" }
289290
rolldown_resolver = { path = "./rolldown/crates/rolldown_resolver" }
290291
rolldown_sourcemap = { path = "./rolldown/crates/rolldown_sourcemap" }

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Vite+ is fully open-source under the MIT license.
2727

2828
`vp release` detects likely checks from `build`, `pack`, `prepack`, `prepublishOnly`, `prepare`, and `vitePlus.release.checkScripts`. Real releases run those checks before publishing unless you pass `--no-run-checks`; dry-runs stay lightweight by default and can opt in with `--run-checks`. `--dry-run` also runs the native publisher in dry-run mode from a temporary release manifest state when the git worktree is clean. Use `--yes` for CI or other non-interactive runs, and `--version <x.y.z>` when retrying a partial publish at an exact version.
2929

30-
Real releases always create git tags after a successful publish. Preview-only flags such as `--skip-publish` and `--no-git-tag` are therefore limited to `--dry-run`.
30+
Real releases always create git tags after a successful publish. When every released package shares the same target version, `vp release` also creates a repository-level `v<version>` tag so GitHub Releases and repo-wide release notes can follow the same watermark. Preview-only flags such as `--skip-publish` and `--no-git-tag` are therefore limited to `--dry-run`.
3131

3232
## Getting Started
3333

crates/vite_global_cli/src/commands/release/first_publish.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ macro_rules! first_publish_checklist {
161161
"`contents: write` and `id-token: write`",
162162
),
163163
text!(
164-
"Push the generated release tags back to origin so the release watermark survives CI.",
164+
"Push the generated release commit and tags back to origin so the release watermark survives CI.",
165165
),
166166
],
167167
),
@@ -901,7 +901,12 @@ mod tests {
901901
assert!(created.contains("git config user.name \"github-actions[bot]\""));
902902
assert!(created.contains("vp release --first-release --yes"));
903903
assert!(created.contains("vp release --yes"));
904-
assert!(created.contains("run: git push origin --tags"));
904+
assert!(created.contains("git push origin HEAD"));
905+
assert!(created.contains("git push origin --tags"));
906+
assert!(
907+
created
908+
.contains("gh release create \"$repo_tag\" --generate-notes --title \"$repo_tag\"")
909+
);
905910
assert!(!created.contains(PACKAGE_MANAGER_SETUP_TOKEN));
906911
assert!(!created.contains(INSTALL_COMMAND_TOKEN));
907912
}

0 commit comments

Comments
 (0)