Skip to content

Commit 74d87a5

Browse files
dguidoclaude
andauthored
Minor cleanups: default TZ to UTC, shellcheck directive, comment clarity (#21)
- Default timezone to UTC instead of America/New_York - Add shellcheck shell=bash directive to .zshrc - Extract docker filter label into local variable in cmd_down - Clarify mount filter comment (target paths immune to project name changes) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a1f3994 commit 74d87a5

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

.zshrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# shellcheck shell=bash
12
# Zsh configuration for Claude Code devcontainer
23

34
# Add Claude Code to PATH

devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"build": {
55
"dockerfile": "Dockerfile",
66
"args": {
7-
"TZ": "${localEnv:TZ:America/New_York}",
7+
"TZ": "${localEnv:TZ:UTC}",
88
"GIT_DELTA_VERSION": "0.18.2",
99
"ZSH_IN_DOCKER_VERSION": "1.2.1"
1010
}

install.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ extract_mounts_to_file() {
109109

110110
temp_file=$(mktemp)
111111

112-
# Filter out default mounts (template mounts we don't want to preserve)
112+
# Filter out default mounts by target path (immune to project name changes)
113113
local custom_mounts
114114
custom_mounts=$(jq -c '
115115
.mounts // [] | map(
@@ -248,8 +248,9 @@ cmd_down() {
248248
log_info "Stopping devcontainer..."
249249

250250
# Get container ID and stop it
251+
local label="devcontainer.local_folder=$workspace_folder"
251252
local container_id
252-
container_id=$(docker ps -q --filter "label=devcontainer.local_folder=$workspace_folder" 2>/dev/null || true)
253+
container_id=$(docker ps -q --filter "label=$label" 2>/dev/null || true)
253254

254255
if [[ -n "$container_id" ]]; then
255256
docker stop "$container_id"

0 commit comments

Comments
 (0)