Skip to content

Commit 7410bf6

Browse files
committed
test(auth): declare PasswordHasher coverage metadata to fix risky tests
Tests executing the new PasswordHasher class triggered PHPUnit risky warnings under beStrictAboutCoverageMetadata. Add #[UsesClass] for PasswordHasher to the consumer tests, and the Configuration/Database stack to PasswordHasherTest.
1 parent 0193062 commit 7410bf6

5 files changed

Lines changed: 43 additions & 0 deletions

File tree

tests/phpMyFAQ/Auth/OAuth2/Repository/UserRepositoryTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use phpMyFAQ\Auth;
1010
use phpMyFAQ\Auth\AuthDatabase;
1111
use phpMyFAQ\Auth\OAuth2\Entity\UserEntity;
12+
use phpMyFAQ\Auth\PasswordHasher;
1213
use phpMyFAQ\Configuration;
1314
use phpMyFAQ\Database;
1415
use phpMyFAQ\Database\DatabaseDriver;
@@ -25,6 +26,7 @@
2526
#[UsesClass(UserEntity::class)]
2627
#[UsesClass(Auth::class)]
2728
#[UsesClass(AuthDatabase::class)]
29+
#[UsesClass(PasswordHasher::class)]
2830
#[UsesClass(Encryption::class)]
2931
class UserRepositoryTest extends TestCase
3032
{

tests/phpMyFAQ/Auth/PasswordHasherTest.php

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,46 @@
55
namespace phpMyFAQ\Auth;
66

77
use phpMyFAQ\Configuration;
8+
use phpMyFAQ\Configuration\ConfigurationRepository;
9+
use phpMyFAQ\Configuration\LayoutSettings;
10+
use phpMyFAQ\Configuration\LdapSettings;
11+
use phpMyFAQ\Configuration\MailSettings;
12+
use phpMyFAQ\Configuration\SearchSettings;
13+
use phpMyFAQ\Configuration\SecuritySettings;
14+
use phpMyFAQ\Configuration\Storage\ConfigurationStorageSettings;
15+
use phpMyFAQ\Configuration\Storage\ConfigurationStorageSettingsResolver;
16+
use phpMyFAQ\Configuration\Storage\DatabaseConfigurationStore;
17+
use phpMyFAQ\Configuration\Storage\HybridConfigurationStore;
18+
use phpMyFAQ\Configuration\UrlSettings;
19+
use phpMyFAQ\Database;
820
use phpMyFAQ\Database\Sqlite3;
21+
use phpMyFAQ\Environment;
22+
use phpMyFAQ\Plugin\PluginManager;
23+
use phpMyFAQ\System;
24+
use phpMyFAQ\Translation;
925
use PHPUnit\Framework\Attributes\CoversClass;
26+
use PHPUnit\Framework\Attributes\UsesClass;
1027
use PHPUnit\Framework\TestCase;
1128

1229
#[CoversClass(PasswordHasher::class)]
30+
#[UsesClass(Configuration::class)]
31+
#[UsesClass(ConfigurationRepository::class)]
32+
#[UsesClass(LayoutSettings::class)]
33+
#[UsesClass(LdapSettings::class)]
34+
#[UsesClass(MailSettings::class)]
35+
#[UsesClass(SearchSettings::class)]
36+
#[UsesClass(SecuritySettings::class)]
37+
#[UsesClass(ConfigurationStorageSettings::class)]
38+
#[UsesClass(ConfigurationStorageSettingsResolver::class)]
39+
#[UsesClass(DatabaseConfigurationStore::class)]
40+
#[UsesClass(HybridConfigurationStore::class)]
41+
#[UsesClass(UrlSettings::class)]
42+
#[UsesClass(Database::class)]
43+
#[UsesClass(Sqlite3::class)]
44+
#[UsesClass(Environment::class)]
45+
#[UsesClass(PluginManager::class)]
46+
#[UsesClass(System::class)]
47+
#[UsesClass(Translation::class)]
1348
class PasswordHasherTest extends TestCase
1449
{
1550
private PasswordHasher $passwordHasher;

tests/phpMyFAQ/Export/PdfTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use phpMyFAQ\Auth;
88
use phpMyFAQ\Auth\AuthDatabase;
9+
use phpMyFAQ\Auth\PasswordHasher;
910
use phpMyFAQ\Category;
1011
use phpMyFAQ\Configuration;
1112
use phpMyFAQ\Configuration\ConfigurationRepository;
@@ -54,6 +55,7 @@
5455
#[UsesClass(Translation::class)]
5556
#[UsesClass(Auth::class)]
5657
#[UsesClass(AuthDatabase::class)]
58+
#[UsesClass(PasswordHasher::class)]
5759
#[UsesClass(Configuration::class)]
5860
#[UsesClass(ConfigurationRepository::class)]
5961
#[UsesClass(LayoutSettings::class)]

tests/phpMyFAQ/NotificationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Monolog\Handler\NullHandler;
66
use Monolog\Logger;
77
use phpMyFAQ\Auth\AuthDatabase;
8+
use phpMyFAQ\Auth\PasswordHasher;
89
use phpMyFAQ\Category\CategoryCache;
910
use phpMyFAQ\Category\CategoryPermissionContext;
1011
use phpMyFAQ\Category\CategoryRepository;
@@ -47,6 +48,7 @@
4748
#[UsesClass(User::class)]
4849
#[UsesClass(Auth::class)]
4950
#[UsesClass(AuthDatabase::class)]
51+
#[UsesClass(PasswordHasher::class)]
5052
#[UsesClass(Database::class)]
5153
#[UsesClass(Encryption::class)]
5254
#[UsesClass(Permission::class)]

tests/phpMyFAQ/Setup/Migration/Operations/UserCreateOperationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use phpMyFAQ\Auth;
66
use phpMyFAQ\Auth\AuthDatabase;
7+
use phpMyFAQ\Auth\PasswordHasher;
78
use phpMyFAQ\Configuration;
89
use phpMyFAQ\Configuration\ConfigurationRepository;
910
use phpMyFAQ\Configuration\LayoutSettings;
@@ -45,6 +46,7 @@
4546
#[UsesClass(User::class)]
4647
#[UsesClass(Auth::class)]
4748
#[UsesClass(AuthDatabase::class)]
49+
#[UsesClass(PasswordHasher::class)]
4850
#[UsesClass(Configuration::class)]
4951
#[UsesClass(ConfigurationRepository::class)]
5052
#[UsesClass(LayoutSettings::class)]

0 commit comments

Comments
 (0)