fix(quality): resolve mago lint findings in the SQLite drivers

Author: thorsten

mago-analyze-baseline.toml

@@ -8308,7 +8308,7 @@ count = 2
 file = "phpmyfaq/src/phpMyFAQ/Database/PdoSqlite.php"
 code = "mixed-assignment"
 message = "Assigning `mixed` type to a variable may lead to unexpected behavior."
-count = 7
+count = 6
 
 [[issues]]
 file = "phpmyfaq/src/phpMyFAQ/Database/PdoSqlite.php"
@@ -8386,7 +8386,7 @@ count = 1
 file = "phpmyfaq/src/phpMyFAQ/Database/PdoSqlite.php"
 code = "possible-method-access-on-null"
 message = "Attempting to call a method on `null`."
-count = 8
+count = 7
 
 [[issues]]
 file = "phpmyfaq/src/phpMyFAQ/Database/PdoSqlsrv.php"

mago-lint-baseline.toml

@@ -156,12 +156,6 @@ code = "literal-named-argument"
 message = "Literal argument `true` should be passed as a named argument for clarity."
 count = 1
 
-[[issues]]
-file = "phpmyfaq/src/phpMyFAQ/Database/Sqlite3.php"
-code = "no-error-control-operator"
-message = "Unsafe use of error control operator `@`."
-count = 1
-
 [[issues]]
 file = "phpmyfaq/src/phpMyFAQ/Entity/FaqEntity.php"
 code = "too-many-properties"
@@ -204,12 +198,6 @@ code = "no-error-control-operator"
 message = "Unsafe use of error control operator `@`."
 count = 1
 
-[[issues]]
-file = "phpmyfaq/src/phpMyFAQ/Faq.php"
-code = "kan-defect"
-message = "Class has a high kan defect score."
-count = 1
-
 [[issues]]
 file = "phpmyfaq/src/phpMyFAQ/Faq.php"
 code = "too-many-methods"

phpmyfaq/src/phpMyFAQ/Database/PdoSqlite.php

@@ -171,21 +171,17 @@ public function numRows(mixed $result): int
                 $inner = rtrim($sql, characters: " \t\n\r\0\x0B;");
                 $countSql = 'SELECT COUNT(*) AS c FROM (' . $inner . ') AS _pmf_cnt';
 
-                if ($result instanceof PDOStatement && isset($this->preparedParams[$result])) {
-                    // Re-bind the original parameters for prepared statements
-                    $stmt = $this->pdo->prepare($countSql);
-                    if ($stmt === false) {
-                        return 0;
-                    }
-
-                    $stmt->execute($this->preparedParams[$result]);
-                } else {
-                    $stmt = $this->pdo->query($countSql);
-                    if ($stmt === false) {
-                        return 0;
-                    }
+                $stmt = $this->pdo->prepare($countSql);
+                if ($stmt === false) {
+                    return 0;
                 }
 
+                // Re-bind the original parameters for prepared statements
+                $params = $result instanceof PDOStatement && $this->preparedParams->offsetExists($result)
+                    ? $this->preparedParams[$result]
+                    : [];
+                $stmt->execute($params);
+
                 $row = $stmt->fetch(PDO::FETCH_NUM);
                 return is_array($row) && array_key_exists(0, $row) ? (int) $row[0] : 0;
             }
@@ -337,7 +333,6 @@ public function query(string $query, int $offset = 0, int $rowcount = 0): mixed
         }
 
         try {
-            /** @var PDOStatement|false $result */
             $result = $this->pdo?->query($query) ?? false;
         } catch (PDOException $pdoException) {
             throw new Exception($pdoException->getMessage());

phpmyfaq/src/phpMyFAQ/Database/Sqlite3.php

@@ -63,6 +63,7 @@ public function connect(
         ?int $port = null,
     ): ?bool {
         $this->conn = new \Sqlite3($host);
+        $this->conn->enableExceptions(true);
 
         return true;
     }
@@ -190,7 +191,11 @@ public function query(string $query, int $offset = 0, int $rowcount = 0): \SQLit
             $query .= sprintf(' LIMIT %d,%d', $offset, $rowcount);
         }
 
-        $result = @$this->conn->query($query);
+        try {
+            $result = $this->conn->query($query);
+        } catch (\SQLite3Exception) {
+            $result = false;
+        }
 
         if (!$result) {
             $this->sqlLog .= $this->error();
@@ -212,7 +217,12 @@ public function queryPrepared(string $query, array $params): \SQLite3Result|bool
             return false;
         }
 
-        $statement = @$this->conn->prepare($query);
+        try {
+            $statement = $this->conn->prepare($query);
+        } catch (\SQLite3Exception) {
+            $statement = false;
+        }
+
         if (!$statement instanceof \SQLite3Stmt) {
             $this->sqlLog .= $this->error();
 
@@ -225,7 +235,12 @@ public function queryPrepared(string $query, array $params): \SQLite3Result|bool
             ++$position;
         }
 
-        $result = @$statement->execute();
+        try {
+            $result = $statement->execute();
+        } catch (\SQLite3Exception) {
+            $result = false;
+        }
+
         if ($result === false) {
             $this->sqlLog .= $this->error();
         }