fix: handle missing active field and cast sticky to bool on FAQ create, closes #4329

When answering an open question, the FAQ editor renders with neither active
radio checked, so FormData omits `active`. Also the sticky checkbox posts
"on", but FaqEntity::setSticky() requires bool.

Author: thorsten

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/FaqController.php

@@ -101,7 +101,7 @@ public function create(Request $request): JsonResponse
 
         $language = Filter::filterVar($data->lang, FILTER_SANITIZE_SPECIAL_CHARS);
         $tags = Filter::filterVar($data->tags, FILTER_SANITIZE_SPECIAL_CHARS);
-        $active = Filter::filterVar($data->active, FILTER_SANITIZE_SPECIAL_CHARS);
+        $active = Filter::filterVar($data->active ?? 'no', FILTER_SANITIZE_SPECIAL_CHARS);
         $sticky = Filter::filterVar($data->sticky ?? 'no', FILTER_SANITIZE_SPECIAL_CHARS);
         $content = Filter::filterVar($data->answer, FILTER_SANITIZE_SPECIAL_CHARS);
         $keywords = Filter::filterVar($data->keywords, FILTER_SANITIZE_SPECIAL_CHARS);
@@ -127,7 +127,7 @@ public function create(Request $request): JsonResponse
         $faqData
             ->setLanguage($language)
             ->setActive($active === 'yes')
-            ->setSticky($sticky !== 'no' ? $sticky : false)
+            ->setSticky($sticky !== 'no')
             ->setQuestion(Filter::removeAttributes(html_entity_decode(
                 (string) $question,
                 ENT_QUOTES | ENT_HTML5,
@@ -311,7 +311,7 @@ public function update(Request $request): JsonResponse
 
         $faqLang = Filter::filterVar($data->lang, FILTER_SANITIZE_SPECIAL_CHARS);
         $tags = Filter::filterVar($data->tags, FILTER_SANITIZE_SPECIAL_CHARS);
-        $active = Filter::filterVar($data->active, FILTER_SANITIZE_SPECIAL_CHARS);
+        $active = Filter::filterVar($data->active ?? 'no', FILTER_SANITIZE_SPECIAL_CHARS);
         $sticky = Filter::filterVar($data->sticky ?? 'no', FILTER_SANITIZE_SPECIAL_CHARS);
         $content = Filter::filterVar($data->answer, FILTER_SANITIZE_SPECIAL_CHARS);
         $keywords = Filter::filterVar($data->keywords, FILTER_SANITIZE_SPECIAL_CHARS);