fix some warnings reported by the modernize family of clang-tidy's checks, particularly those related to mising [[nodiscard]] attributes

Author: thelfer

CMakeLists.txt

@@ -21,6 +21,9 @@ install(FILES "${PROJECT_BINARY_DIR}/mgis-config-version.cmake"
 set(CMAKE_CXX_STANDARD 20)
 set(CXX_STANDARD_REQUIRED ON)
 
+# enable tests
+option(enable-testing "" ON)
+
 # portable-build
 option(enable-portable-build "produce binary that can be shared between various machine (same architecture, same gcc version, different processors" OFF)
 
@@ -274,26 +277,30 @@ endif(enable-website)
 
 add_subdirectory(docs)
 
-# testing
-set(CTEST_CONFIGURATION_TYPE "${JOB_BUILD_CONFIGURATION}")
-# (must be placed *before* any add_subdirectory, cmake bug ?)
-enable_testing()
-
-if(CMAKE_VERSION VERSION_GREATER 3.21.4)
-  set(ctest_args )
-  list(APPEND ctest_args --output-junit ctest-results.xml) 
-endif(CMAKE_VERSION VERSION_GREATER 3.21.4)
-if(CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(check COMMAND
-    ${CMAKE_CTEST_COMMAND} ${ctest_args} -T test -C $<CONFIGURATION>)
-else(CMAKE_CONFIGURATION_TYPES)
-  add_custom_target(check COMMAND
-    ${CMAKE_CTEST_COMMAND} ${ctest_args} -T test )
-endif(CMAKE_CONFIGURATION_TYPES)
+if(enable-testing)
+  # testing
+  set(CTEST_CONFIGURATION_TYPE "${JOB_BUILD_CONFIGURATION}")
+  # (must be placed *before* any add_subdirectory, cmake bug ?)
+  enable_testing()
+  
+  if(CMAKE_VERSION VERSION_GREATER 3.21.4)
+    set(ctest_args )
+    list(APPEND ctest_args --output-junit ctest-results.xml) 
+  endif(CMAKE_VERSION VERSION_GREATER 3.21.4)
+  if(CMAKE_CONFIGURATION_TYPES)
+    add_custom_target(check COMMAND
+      ${CMAKE_CTEST_COMMAND} ${ctest_args} -T test -C $<CONFIGURATION>)
+  else(CMAKE_CONFIGURATION_TYPES)
+    add_custom_target(check COMMAND
+      ${CMAKE_CTEST_COMMAND} ${ctest_args} -T test )
+  endif(CMAKE_CONFIGURATION_TYPES)
+endif(enable-testing)
 
 add_subdirectory(include)
 add_subdirectory(src)
-add_subdirectory(tests)
+if(enable-testing)
+  add_subdirectory(tests)
+endif(enable-testing)
 add_subdirectory(bindings)
 # shall be included after the other directories
 add_subdirectory(env)

INSTALL-cmake.md

@@ -53,6 +53,7 @@ Options
   pandoc is found)
 - `enable-portable-build`: do not use processor specific flags.
 - `enable-static`: compiles static libraries
+- `enable-testing`: enable compilation of tests
 - `enable-doxygen-doc`: enable the generation of the API documentation
   using with `Doxygen`.
 - `disable-tfel`: by default, `MGIS` tries to add support for `TFEL`,

bindings/c/CMakeLists.txt

@@ -1,5 +1,5 @@
 add_subdirectory(include)
 add_subdirectory(src)
-if(MGIS_HAVE_MFRONT_SUPPORT)
+if(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)
   add_subdirectory(tests)
-endif(MGIS_HAVE_MFRONT_SUPPORT)
+endif(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)

bindings/c/src/Status.cxx

@@ -20,14 +20,14 @@
 extern "C" {
 
 mgis_status mgis_report_success() {
-  return {MGIS_SUCCESS, nullptr};
+  return {.exit_status = MGIS_SUCCESS, .msg = nullptr};
 }  // end of mgis_status mgis_report_success
 
 mgis_status mgis_report_failure(const char* const e) {
   static thread_local char msg[512];
   ::strncpy(msg, e, 511);
   msg[511] = '\0';
-  return {MGIS_FAILURE, msg};
+  return {.exit_status = MGIS_FAILURE, .msg = msg};
 }  // end of mgis_status mgis_report_failure
 
 mgis_status mgis_handle_cxx_exception() {

bindings/fenics/CMakeLists.txt

@@ -1,5 +1,5 @@
 add_subdirectory(include)
 add_subdirectory(src)
-if(MGIS_HAVE_TFEL)
+if(MGIS_HAVE_TFEL AND enable-testing)
   add_subdirectory(tests)
-endif(MGIS_HAVE_TFEL)
+endif(MGIS_HAVE_TFEL AND enable-testing)

bindings/fortran/CMakeLists.txt

@@ -1,6 +1,6 @@
 add_subdirectory(src)
 add_subdirectory(modules)
-if(MGIS_HAVE_MFRONT_SUPPORT)
+if(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)
   add_subdirectory(tests)
-endif(MGIS_HAVE_MFRONT_SUPPORT)
+endif(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)
 

bindings/python/CMakeLists.txt

@@ -1,5 +1,5 @@
 add_subdirectory(src)
 add_subdirectory(mgis)
-if(MGIS_HAVE_MFRONT_SUPPORT)
+if(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)
   add_subdirectory(tests)
-endif(MGIS_HAVE_MFRONT_SUPPORT)
+endif(MGIS_HAVE_MFRONT_SUPPORT AND enable-testing)

bindings/python/src/Function.cxx

@@ -11,9 +11,10 @@
 #include "MGIS/Function/Function.hxx"
 #include "MGIS/Function/BasicLinearSpace.hxx"
 
-mgis::function::FunctionView<mgis::function::BasicLinearSpace,
-                             mgis::function::FunctionDataLayoutDescription{},
-                             false>
+static mgis::function::FunctionView<
+    mgis::function::BasicLinearSpace,
+    mgis::function::FunctionDataLayoutDescription{},
+    false>
 mgis_convert_to_span(const pybind11::array_t<double> &o) {
   using namespace mgis::function;
   const auto i = o.request();
@@ -26,6 +27,7 @@ mgis_convert_to_span(const pybind11::array_t<double> &o) {
   mgis::raise("convert_to_span: expected one dimensional array");
 }  // end of mgis_convert_to_span
 
+void declareFunction(pybind11::module_ &);
 void declareFunction(pybind11::module_ &m) {
   // FunctionView<BasicLinearSpace, FunctionDataLayoutDescription{}, false
   using mgis::real;

include/MGIS/Behaviour/BehaviourData.hxx

@@ -58,7 +58,7 @@ namespace mgis::behaviour {
      */
     char* error_message;
     //! \brief time increment
-    mgis::real dt;
+    real dt = real{};
     /*!
      * \brief the stiffness matrix.
      *

include/MGIS/Behaviour/BehaviourIntegrationFailureAnalyser.hxx

@@ -59,7 +59,8 @@ namespace mgis::behaviour::debug {
      * a significant overhead and is normally not required for correctly written
      * behaviours but data corruption may occur, so copying is safer.
      */
-    virtual bool shallCopyBehaviourDataBeforeIntegration() const noexcept = 0;
+    [[nodiscard]] virtual bool shallCopyBehaviourDataBeforeIntegration()
+        const noexcept = 0;
     //! \brief destructor
     virtual ~BehaviourIntegrationFailureAnalyser() noexcept;
   };