From ab407035e851935c4d33a5411ec74290e6344479 Mon Sep 17 00:00:00 2001 From: nohwnd Date: Wed, 1 Jul 2026 23:47:34 +0200 Subject: [PATCH] Also fail on Pester block/container failures, not just failed tests In Pester 5 a run has three independent failure counts. Gating only on FailedCount misses FailedBlocksCount (BeforeAll/AfterAll) and FailedContainersCount (files that fail to discover/load), so a failing BeforeAll or an unloadable test file passes the build green. This adds those counts to the gate. Generated with AI (GitHub Copilot CLI). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/Catesta.build.ps1 | 4 ++-- src/Catesta/Resources/Module/src/PSModule.build.ps1 | 4 ++-- src/Catesta/Resources/Vault/src/PSVault.build.ps1 | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Catesta.build.ps1 b/src/Catesta.build.ps1 index cf8d283..bfcb835 100644 --- a/src/Catesta.build.ps1 +++ b/src/Catesta.build.ps1 @@ -303,7 +303,7 @@ Add-BuildTask Test { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) if ($testResults.CodeCoverage.CommandsExecutedCount -ne 0 -and $coverageThreshold -ne 0) { @@ -627,7 +627,7 @@ Add-BuildTask IntegrationTest { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) Write-Build Green ' ...Pester Integration Tests Complete!' } diff --git a/src/Catesta/Resources/Module/src/PSModule.build.ps1 b/src/Catesta/Resources/Module/src/PSModule.build.ps1 index c689214..d7716b6 100644 --- a/src/Catesta/Resources/Module/src/PSModule.build.ps1 +++ b/src/Catesta/Resources/Module/src/PSModule.build.ps1 @@ -379,7 +379,7 @@ elseif ($PLASTER_PARAM_Pester -eq '5') { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) <% @@ -777,7 +777,7 @@ elseif ($PLASTER_PARAM_Pester -eq '5') { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) Write-Build Green ' ...Pester Integration Tests Complete!' } diff --git a/src/Catesta/Resources/Vault/src/PSVault.build.ps1 b/src/Catesta/Resources/Vault/src/PSVault.build.ps1 index 7807889..7aaa6fa 100644 --- a/src/Catesta/Resources/Vault/src/PSVault.build.ps1 +++ b/src/Catesta/Resources/Vault/src/PSVault.build.ps1 @@ -368,7 +368,7 @@ elseif ($PLASTER_PARAM_Pester -eq '5') { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) <% @@ -535,7 +535,7 @@ elseif ($PLASTER_PARAM_Pester -eq '5') { } } - $numberFails = $testResults.FailedCount + $numberFails = ($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) Assert-Build($numberFails -eq 0) ('Failed "{0}" unit tests.' -f $numberFails) Write-Build Green ' ...Pester Integration Tests Complete!' }