Skip to content

replace the old auth code from our MinIO fork #95

Description

@amwolff

Because of #89, there was work encompassing #90, #91, and #92, which was a side project that I've put into a package here. I've done my best to have the API surface be as succinct as possible and for the potential project of plowing through the old auth code in our MinIO fork to go as smoothly as possible, so I believe that it should be possible to go handler by handler, replacing the auth code.

There are instructions on how to use the library in the linked README.md file.

I think it should be possible to:

  1. implement CredentialsProvider in such a way that the MinIO fork receives it from the calling code
        1. in Gateway-ST, CredentialsProvider can be very simple
        2. in Gateway-MT, authclient should implement CredentialsProvider or an implementation should call it
  2. have the old auth code work alongside the new auth code
  3. after going through each bucket/object handler, run the entire CI suite, verifying nothing broke
  4. once every important handler has been adjusted, we can fully get rid of the legacy auth code

This is a significant amount of work, so we might want to partition this issue into subissues that resemble the list above, and we could even partition the work for (4) into an issue per handler.

I don't think we should make support for all available integrity options a requirement for this issue to be completed. I believe it should be another (hopefully small) project.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions