From 8f5d2abad0612da959f5b0740c141339ea7cdfcb Mon Sep 17 00:00:00 2001 From: harsha573252 Date: Thu, 18 Jun 2026 17:13:19 +0530 Subject: [PATCH] Added unique IDs to expander landmarks --- .../bits/e2e/components/expander/expander.a11y.spec.ts | 1 - packages/bits/src/lib/expander/expander.component.html | 2 +- packages/bits/src/lib/expander/expander.component.ts | 7 ++++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/bits/e2e/components/expander/expander.a11y.spec.ts b/packages/bits/e2e/components/expander/expander.a11y.spec.ts index aed84b722..8ee3bd227 100644 --- a/packages/bits/e2e/components/expander/expander.a11y.spec.ts +++ b/packages/bits/e2e/components/expander/expander.a11y.spec.ts @@ -28,7 +28,6 @@ test.describe("a11y: expander", () => { const rulesToDisable: string[] = [ "aria-required-children", "aria-dialog-name", - "landmark-unique", "aria-command-name", "nested-interactive", ]; diff --git a/packages/bits/src/lib/expander/expander.component.html b/packages/bits/src/lib/expander/expander.component.html index 1c56708c2..837b115c4 100644 --- a/packages/bits/src/lib/expander/expander.component.html +++ b/packages/bits/src/lib/expander/expander.component.html @@ -50,7 +50,7 @@
./../examples/index.html#/expander */ @@ -84,10 +86,13 @@ export class ExpanderComponent implements AfterContentInit { public state: "expanded" | "collapsed" = "collapsed"; public isCustomHeaderContentEmpty: boolean = false; + public uniqueId: string; private actionKeys = [KEYBOARD_CODE.SPACE, KEYBOARD_CODE.ENTER].map(String); - constructor(private cdRef: ChangeDetectorRef) {} + constructor(private cdRef: ChangeDetectorRef) { + this.uniqueId = String(++nextExpanderId); + } public ngAfterContentInit(): void { this.isCustomHeaderContentEmpty =