Feature/improvement
Just noticed that commands.wait types aren't complete, now wait is just a function, but in the JavaScript code, it's also an object with by* methods. I'd fix this myself, but I'm not sure whether we should use by* methods or not with sitespeed v40+. And if not, there's a question again. While byTime method, for example, is likely easy-to-implement by using something like promisify(setTimeout), byPageToComplete relies on a page complete check which is configured in the CLI so not so easy to implement on the user's side.
What should we do with all this, @soulgalore ?
Feature/improvement
Just noticed that
commands.waittypes aren't complete, nowwaitis just a function, but in the JavaScript code, it's also an object withby*methods. I'd fix this myself, but I'm not sure whether we should useby*methods or not with sitespeed v40+. And if not, there's a question again. WhilebyTimemethod, for example, is likely easy-to-implement by using something likepromisify(setTimeout),byPageToCompleterelies on a page complete check which is configured in the CLI so not so easy to implement on the user's side.What should we do with all this, @soulgalore ?