Write and use consolidated metadata - #492
Conversation
|
I'll stop here for a first review & merge if this seems good. The 2nd stage, which will bring reading from S3 and further performance improvement, will require changing the signature of some helper function, so I prefer to do it in a dedicated PR. For example, |
Since consolidated metadata is now always returned under v3 format
|
| Project | anndataR |
| Branch | consolidated-metadata |
| Testbed | ubuntu-latest |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🚨 9 Alerts
🐰 View full continuous benchmarking report in Bencher
lazappi
left a comment
There was a problem hiding this comment.
I think this looks good. Does there need to be any checks for the Zarr version?
| Package: anndataR | ||
| Title: AnnData interoperability in R | ||
| Version: 1.3.1 | ||
| Version: 1.3.2 |
There was a problem hiding this comment.
I'm not sure if we want to bump this yet (I've lost track of how we were managing versions, @rcannood might have a plan)
From Rarr's side, no. Consolidated metadata is generated, and would be beneficial, for both v2 and v3. I don't know if the anndata spec is strict about this but my view is that even if anndata python doesn't generate it / use it for v2, they are not likely to be hindered by it either. |
Related to: fix #461
Description
In line of what anndata python is doing, this PR:
Eventually, in a follow up PR, this can also be used to add reading from S3.
Checklist
Before review
Before merge
NEWS