This repository was archived by the owner on May 31, 2025. It is now read-only.
Cherry-picking various commits from Melodic#471
Merged
Conversation
the variables are not used in function body and caused -Wunused-parameter to trigger with -Wall
* rework ambiguous call on MSVC.
23 tasks
8 tasks
Contributor
Author
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-08-20/16063/1 |
tfoote
approved these changes
Aug 24, 2020
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Thanks for porting these forward.
Contributor
Author
|
Thanks for merging, @tfoote. Could you, please, prepare a new Noetic release as well to unblock MoveIt? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Noetic release is missing various commits from the Melodic branch, most importantly #436, which reverted #367, which in turn was causing build issues in MoveIt. For this reason, the MoveIt release into Noetic is currently blocked.
Please cherry-pick those missing commits and prepare a new release into Noetic.
Note, that the list below includes https://github.com/ros/geometry2/tree/forward_port_444.